Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uid function code optimization #2751

Closed
wants to merge 1 commit into from

Conversation

Altermoe
Copy link

optimize by functional programing

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

  • fix(@formily/shared/uid): code optimization
    • Optimize by functional programing
    • Better performance when larger uid init

optimize by functional programing
@CLAassistant
Copy link

CLAassistant commented Jan 11, 2022

CLA assistant check
All committers have signed the CLA.

@Altermoe Altermoe changed the title fix(@formily/shared/uid): code optimization fix: uid function code optimization Jan 11, 2022
@janryWang
Copy link
Collaborator

调用这么多次遍历方法,性能还好?确定做过benchmark了吗

@janryWang janryWang closed this Jan 13, 2022
@Altermoe Altermoe deleted the patch-1 branch January 13, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants