Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(antd/next): array-collapse onAdd function nullable issue #3795

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

McDaddy
Copy link
Contributor

@McDaddy McDaddy commented Apr 18, 2023

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

不好意思没注意到onAdd的类型可能是undefined,但我很奇怪,为什么我的编辑器显示的类型是非空,但是看IArrayBaseProps的定义却都是optiional的

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cce787c) 96.58% compared to head (3c2a917) 96.58%.

Additional details and impacted files
@@              Coverage Diff              @@
##           formily_next    #3795   +/-   ##
=============================================
  Coverage         96.58%   96.58%           
=============================================
  Files               152      152           
  Lines              6669     6669           
  Branches           1856     1856           
=============================================
  Hits               6441     6441           
  Misses              200      200           
  Partials             28       28           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@janryWang janryWang merged commit 39fac2b into alibaba:formily_next Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants