Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphScope 1/3: Enable macos compatibility #208

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

sighingnow
Copy link
Collaborator

@sighingnow sighingnow commented Jul 20, 2022

The rebase & merge graphscope task will include three pull requests to make code review easier:

  • handling platform compatibility issues, especially for MacOS and using pre-installed packages as dependencies
  • add the graphscope storage implementation based on vineyard
  • revisit python API / examples and testing

This pull request is the first one of the patch series, includes:

  • necessary cmake to find dependencies
  • pthread compatibility layer for MacOS
  • removing the usages of tr1 as we have already moved to C++14 in CMakeLists.txt
  • fixes the double-initialization/destruction bug in glog's logger

Signed-off-by: Tao He <sighingnow@gmail.com>
Copy link
Collaborator

@goldenleaves goldenleaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it is better to put this cmake folder in the upper directory, because thrid parties are currently being sharedby graphlearn module and dgs module.

@sighingnow
Copy link
Collaborator Author

I think that it is better to put this cmake folder in the upper directory, because thrid parties are currently being sharedby graphlearn module and dgs module.

Okay

Signed-off-by: Tao He <sighingnow@gmail.com>
Copy link
Collaborator

@goldenleaves goldenleaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Seventeen17 Seventeen17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants