GraphScope on 3/3 part 2: pick up the previous graphscope functions #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tao He <sighingnow@gmail.com>
sighingnow
changed the title
Signed-off-by: Tao He <sighingnow@gmail.com>
baoleai
reviewed
Nov 23, 2022
graphlearn/python/client.py
Outdated
| # one server finish, start to connect next server | ||
| if self._client_cache[next_index] is None: | ||
| self._client_cache[next_index] = pywrap.rpc_client( | ||
| self._own_servers[next_index], True, True |
There was a problem hiding this comment.
There are only two args for pywrap.rpc_client
Signed-off-by: Tao He <sighingnow@gmail.com>
Signed-off-by: Tao He <sighingnow@gmail.com>
Signed-off-by: Tao He <sighingnow@gmail.com>
Seventeen17
reviewed
Nov 25, 2022
graphlearn/python/gsl/dag_dataset.py
Outdated
| self._current_index = (self._current_index + 1) % len(self._client) | ||
| # initialize the dataset for the next client | ||
| if self._dag_datasets[self._current_index] is None: | ||
| status = self._client.run_dag(self._dag.dag_def, self._current_index != len(self._client) - 1) |
There was a problem hiding this comment.
Maybe we can register dag on all the servers this client owned at once, to avoid delay with warming up when moving and consuming samples on next server.
Signed-off-by: Tao He <sighingnow@gmail.com>
Seventeen17
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request picks up necessary routines to support using graphlearn in the context of graphscope (see also the original work in e56fc9c).
This pull request has done a lot of cleanup and simplification, the main changes there are:
Clientclass to support connecting to multiple servers from one client