Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for cors annotations #171

Closed
johnlanni opened this issue Feb 6, 2023 · 2 comments
Closed

Add e2e test for cors annotations #171

johnlanni opened this issue Feb 6, 2023 · 2 comments
Assignees
@Hinsteny
Labels
area/e2e level/normal

Comments

@johnlanni
Copy link
Collaborator

annotation docs：https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#enable-cors
e2e framework: https://github.com/alibaba/higress/tree/main/test
@johnlanni johnlanni added help wanted Extra attention is needed level/normal area/e2e labels Feb 6, 2023
@Hinsteny
Copy link
Collaborator

Hinsteny commented Feb 6, 2023

Please assign this issue to me, tks

Hinsteny added a commit to Hinsteny/higress that referenced this issue Feb 8, 2023
@Hinsteny
Add e2e test for cors annotations alibaba#171
65136ee
@Hinsteny Hinsteny mentioned this issue Feb 8, 2023
Merged
@johnlanni johnlanni removed the help wanted Extra attention is needed label Feb 8, 2023
Hinsteny added a commit to Hinsteny/higress that referenced this issue Feb 9, 2023
@Hinsteny
Add e2e test for cors annotations alibaba#171
fcf089c
Hinsteny added a commit to Hinsteny/higress that referenced this issue Feb 10, 2023
@Hinsteny
Add e2e test for cors annotations alibaba#171
bb20386
Hinsteny added a commit to Hinsteny/higress that referenced this issue Feb 10, 2023
@Hinsteny
Add e2e test for cors annotations alibaba#171
349eec7
Xunzhuo added a commit that referenced this issue Feb 14, 2023
@Hinsteny @Xunzhuo
Add e2e test for cors annotations #171 (#179)
6efa393 
Co-authored-by: Xunzhuo <bitliu@tencent.com>
@Xunzhuo
Copy link
Collaborator

Xunzhuo commented Feb 14, 2023

Fixed: #179

@Xunzhuo Xunzhuo closed this as completed Feb 14, 2023
@Xunzhuo Xunzhuo mentioned this issue Feb 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hinsteny Hinsteny

Labels
area/e2e level/normal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Hinsteny @johnlanni @Xunzhuo