Add e2e test for cors annotations #171 #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Xunzhuo
requested changes
Feb 8, 2023
There was a problem hiding this comment.
Thanks for picking this up @Hinsteny. Please refer to current higress supported cors annotations to cover them all.
| nginx.ingress.kubernetes.io/enable-cors | Ingress | 兼容 | 开启或关闭跨域 |
|---|---|---|---|
| nginx.ingress.kubernetes.io/cors-allow-origin | Ingress | 兼容 | 允许的第三方站点 |
| nginx.ingress.kubernetes.io/cors-allow-methods | Ingress | 兼容 | 允许的请求方法，如GET、POST、PUT等 |
| nginx.ingress.kubernetes.io/cors-allow-headers | Ingress | 兼容 | 允许的请求Header |
| nginx.ingress.kubernetes.io/cors-expose-headers | Ingress | 兼容 | 允许的暴露给浏览器的响应Header |
| nginx.ingress.kubernetes.io/cors-allow-credentials | Ingress | 兼容 | 是否允许携带凭证信息 |
| nginx.ingress.kubernetes.io/cors-max-age | Ingress | 兼容 | 预检结果的最大缓存时间 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
- Coverage 42.41% 42.39% -0.03%
==========================================
Files 29 29
Lines 4866 4866
==========================================
- Hits 2064 2063 -1
- Misses 2641 2642 +1
Partials 161 161
|
Hinsteny
force-pushed
the
test/e2e_test_for_enablt_cors
branch
from
65136ee
to
fcf089c
Compare
|
Thanks @Hinsteny, ping me when you are ready for review. |
Hinsteny
force-pushed
the
test/e2e_test_for_enablt_cors
branch
from
fcf089c
to
bb20386
Compare
|
@Xunzhuo Please help to Review it again |
Hinsteny
force-pushed
the
test/e2e_test_for_enablt_cors
branch
from
bb20386
to
349eec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add e2e test for cors annotations #171
Ⅱ. Does this pull request fix one issue?
NO
Ⅲ. Why don't you add test cases (unit test/integration test)?
this is a test PR
Ⅳ. Describe how to verify it
verify by make e2e test
Ⅴ. Special notes for reviews