Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gzip global setting in configmap #660

Merged
merged 8 commits into from
Dec 18, 2023

Conversation

2456868764
Copy link
Collaborator

Ⅰ. Describe what this PR did

add gzip global setting in configmap

Ⅱ. Does this pull request fix one issue?

fixes #410

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Merging #660 (f6a2b8e) into main (324e0bc) will decrease coverage by 2.08%.
Report is 16 commits behind head on main.
The diff coverage is 41.89%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
- Coverage   36.00%   33.93%   -2.08%     
==========================================
  Files          73       78       +5     
  Lines       10339    11191     +852     
==========================================
+ Hits         3723     3798      +75     
- Misses       6330     7099     +769     
- Partials      286      294       +8     
Files Coverage Δ
pkg/ingress/kube/configmap/config.go 0.00% <0.00%> (ø)
pkg/ingress/kube/configmap/tracing.go 0.00% <0.00%> (ø)
pkg/ingress/kube/configmap/controller.go 0.00% <0.00%> (ø)
pkg/ingress/kube/configmap/gzip.go 42.66% <42.66%> (ø)

... and 13 files with indirect coverage changes

@johnlanni
Copy link
Collaborator

@2456868764 需要补充一下UT和e2e测试

@johnlanni
Copy link
Collaborator

#703

可以基于这个实现一下e2e test

@2456868764
Copy link
Collaborator Author

#703

可以基于这个实现一下e2e test

我加了 UT 和 e2e 测试, e2e 测试是根据返回头 content-encoding": "gzip" 来判断,测试了 MinContentLength 和 Content Type,满足e2e 测试要求。 加 envoy配置测试要等到 #703 这个issue 好才加

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 3cc1c78 into alibaba:main Dec 18, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

higress 支持不同content_type 压缩处理
3 participants