Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support empty config with custom config func #718

Conversation

johnlanni
Copy link
Collaborator

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #716

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a140f78) 34.02% compared to head (9f4a5e6) 34.05%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
+ Coverage   34.02%   34.05%   +0.02%     
==========================================
  Files          78       78              
  Lines       11191    11191              
==========================================
+ Hits         3808     3811       +3     
+ Misses       7090     7088       -2     
+ Partials      293      292       -1     

see 1 file with indirect coverage changes

@johnlanni johnlanni merged commit 4ea85e9 into alibaba:main Dec 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

当插件配置yaml为空的时候,代码里读取配置会报错,希望可以兼容一下
2 participants