feat: useAsync add params & autoCancel #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/umijs/hooks/n3yrjrb58 |
brickspert
reviewed
Oct 28, 2019
| } | ||
| if (runCount === count.current) { | ||
| if (!autoCancel || runCount === count.current) { |
There was a problem hiding this comment.
It is best to add a note here.
because it‘s consistent with the above conditions.
it is easy to think that it is redundant.
| @@ -120,24 +125,25 @@ function useAsync<Result = any>( | |||
| // 确保不会返回被取消的结果 | |||
| const runCount = count.current; | |||
| set(s => ({ ...s, loading: true })); | |||
| params.current = args; | |||
There was a problem hiding this comment.
Should be in front of set(s => ({ ...s, loading: true }));
brickspert
reviewed
Oct 28, 2019
| run: promiseReturn, | ||
| timer: { | ||
| stop: noop, | ||
| resume: promiseReturn, | ||
| pause: noop, | ||
| }, | ||
| }); | ||
| const { autoCancel = true } = _options; |
There was a problem hiding this comment.
autoCancel is not a good name~~
but i don't hav any idea~ hhh
docs will be rewritten in the docs branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #65, resolve #69