Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: polling support pollingErrorRetryCount #1657

Merged
merged 6 commits into from
Jun 16, 2022

Conversation

GpingFeng
Copy link
Contributor

@GpingFeng GpingFeng commented Jun 8, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#1645

💡 Background and solution

在轮询 plugin 中添加了一个字段 pollingErrorRetryCount ,用于判断进行重试的次数判断。

retryCount 是重试的 plugin 使用了,不打算使用这个字段,两者的职责不同

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ guangping.feng
❌ crazylxr


guangping.feng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@GpingFeng
Copy link
Contributor Author

#1645

@GpingFeng GpingFeng changed the title fix: 轮询支持pollingErrorRetryCount fix: polling support pollingErrorRetryCount Jun 8, 2022
@crazylxr crazylxr merged commit b894121 into alibaba:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants