Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix iptables clean deprecated rules error #47

Conversation

hhyasdf
Copy link
Collaborator

@hhyasdf hhyasdf commented Aug 27, 2021

Pull Request Description

Describe what this PR does / why we need it

  1. Fix clean iptables deprecated rules error, cause panic while running in a environment without "RAMA-XXX" deprecated chains and rules.
  2. Change alpine image version to 3.12 to avoid DNS resolving error, reference to DNS lookups broken in 3.14 (minikube & mac using virtualbox) alpinelinux/docker-alpine#185.

Does this pull request fix one issue?

Describe how you did it

Need to ensure chains exist first and clean all the deprecated chains and rules.

Describe how to verify it

Update to newest image in "Rama" environment

Special notes for reviews

@hhyasdf hhyasdf requested a review from mars1024 August 27, 2021 13:51
Copy link
Collaborator

@mars1024 mars1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a better choice to force reboot when bumping up rama to hybridnet?

@mars1024
Copy link
Collaborator

Since this is a broken change, downward compatibility should be be our concern.

Copy link
Collaborator

@mars1024 mars1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

This is most for downgrade compatibility, need to be removed in a further version up.

@mars1024 mars1024 merged commit 02dbebc into alibaba:main Aug 30, 2021
@hhyasdf hhyasdf deleted the bugfix/fix-iptables-clean-deprecated-rules-error branch April 18, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants