Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blockGroup db #1145

Merged
merged 1 commit into from Dec 14, 2018
Merged

feat: add blockGroup db #1145

merged 1 commit into from Dec 14, 2018

Conversation

chenbin92
Copy link
Collaborator

@chenbin92 chenbin92 commented Dec 10, 2018 •
edited

  • 在根目录下新建 database 目录，用于存放一些常用的数据配置

@chenbin92
Copy link
Collaborator Author

@imsobear @fenglai0802 看看这个数据这样维护是否合理，有没有更好的建议，这些数据本质上是一份字典，会根据埋点数据和新组合进行不断的调整

@imsobear
Copy link
Collaborator

@chenbin92 放在 github 上维护没有问题，同步 oss 的策略呢？

@chenbin92
Copy link
Collaborator Author

@imsobear 目前是手动拷贝的，我加个脚本吧

@imsobear
Copy link
Collaborator

@chenbin92 可以先手动拷贝，目前更新频率不高，问题不大，我先合掉了

imsobear
imsobear approved these changes Dec 14, 2018
View reviewed changes
Copy link
Collaborator

@imsobear imsobear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@imsobear imsobear merged commit 356ee0a into master Dec 14, 2018
@chenbin92 chenbin92 deleted the add-block-group-db branch December 14, 2018 03:02
@weekly-digest weekly-digest bot mentioned this pull request Dec 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imsobear imsobear imsobear approved these changes

@fenglai0802 fenglai0802 Awaiting requested review from fenglai0802

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chenbin92 @imsobear