Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.2.1 依旧还有 UDP 端口监听 #10824

Closed
doufum opened this issue Jul 20, 2023 · 13 comments
Closed

v2.2.1 依旧还有 UDP 端口监听 #10824

doufum opened this issue Jul 20, 2023 · 13 comments
Labels
area/Client Related to Nacos Client SDK contribution welcome kind/enhancement Category issues or prs related to enhancement.
Milestone

Comments

@doufum
Copy link

doufum commented Jul 20, 2023

请问一下,我们已经将 nacos 的版本升级到v2.2.1了,但是还是可以扫描出 udp 的端口创建。请问一下,这个 upd 端口创建的删除,是要在哪个版本取消?
图片

P.S. 之前询问是在 2.2 版本取消

Originally posted by @doufum in #8747 (comment)

@KomachiSion KomachiSion added area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement. labels Jul 25, 2023
@KomachiSion KomachiSion added this to the 2.3.0 milestone Jul 25, 2023
@KomachiSion
Copy link
Collaborator

确实应该取消, 可能社区中忘记去掉了。欢迎提交PR移除。

@stone-98
Copy link
Contributor

我理解nacos2.x也应该支持udp呀,如果Client使用的低版本的不支持grpc,nacos服务端就要使用udp进行推送了,竟然要使用udp推送那么就需要开放udp端口接收ack呀。还是我理解有误嘛?

@stone-98
Copy link
Contributor

嗷嗷,我理解错了,这说的是nacos-client。。。

@stone-98
Copy link
Contributor

但是目前客户端的已经被移除了吧。#9394

@ZhangShenao
Copy link
Contributor

2.2版本的nacos-client里,com.alibaba.nacos.client.naming.remote.http.NamingHttpClientProxy#UDP_PORT_PARAM 这个UDP请求参数是不是应该去掉了?

@ZhangShenao
Copy link
Contributor

@i will solve it@

@stone-98
Copy link
Contributor

我理解这个参数应该是不能去除的,他是作用于查询实例的参数,就算是你nacos2.x版本的通过udpport去查询v1的服务我理解是没问题的。不知道我理解对了么。

@ZhangShenao
Copy link
Contributor

我看udpPort参数只是在v1版本的InstanceController#list里才会用到,是为了兼容v1版本client的请求,v2版本好像已经不会处理这个参数了。

@stone-98
Copy link
Contributor

嗷嗷,我之前没有注意到这一点,刚刚我看了v2版本的服务端的确没有对udpport进行处理,我不知道v1版本使用udpport查询的场景是什么?如果使用udpport进行查询如果在v2版本有对应的使用场景的话,那感觉就要到服务端把这个udpport的处理逻辑补全,不然就从com.alibaba.nacos.client.naming.remote.NamingClientProxy#queryInstancesOfService方法中完全移除udpport参数,不然容易产生误导,像我就被误导了。具体看看大佬怎么说。

@ZhangShenao
Copy link
Contributor

是的~

@stone-98
Copy link
Contributor

@KomachiSion 大佬这个需要根据udpport查询用于什么场景呀?

@KomachiSion
Copy link
Collaborator

KomachiSion commented Aug 4, 2023

我看了下, 最新的2.2.4版本已经移除了对udp端口的监听, 现在其实就是这个参数的问题对吧。

这个端口是1.x客户端,使用http请求订阅的时候,需要告诉服务端,他的udp端口,服务端才能根据这个端口启动udp推送数据。

所以2.0客户端中, 这个参数只是作为适配参数保留, 现在应该是可以移除的,移除方法最好是分三步:

  1. 移除NamingHttpClientProxy中queryInstancesOfService实现, 换成UnsupportedException。
  2. 修改queryInstancesOfService的接口描述, 移除udpPort的入参
  3. 移除客户端关于udp端口的设置。

@KomachiSion
Copy link
Collaborator

这个接口是内部接口, 修改描述不会影响正常使用的用户。

KomachiSion pushed a commit that referenced this issue Aug 4, 2023
* Remove UDP Param

* Fix gRPC client

* fix test case

* fix test case

* fix test case

* fix test case
realJackSun added a commit that referenced this issue Aug 10, 2023
…lop branch (#10942)

* [ISSUE #10734] Implement http request param check filter and http param extractors (#10758)

* For #10734,Implement grpc server interceptor and grpc param extractors

* For #10734,add unit test for grpc server interceptor and grpc param extractors

* For #10734,alter the test case

* For #10734,delete the ConnectionSetupRequestParamExtractor

* For #10734,add the naming http request param check filter and implement the naming http request param extractors

* For #10734,add unit test for naming http request param extractors

* For #10734,Implement grpc server interceptor and grpc param extractors

* For #10734,add unit test for grpc server interceptor and grpc param extractors

* For #10734,delete the ConnectionSetupRequestParamExtractor

* For #10734,add the naming http request param check filter and implement the naming http request param extractors

* For #10734,add unit test for naming http request param extractors

* For #10734,add the config http request param check filter and implement the config http request param extractors and unit test

* For #10734,add the console http request param check filter and implement the console http request param extractors and unit test

* For #10734,fix code style

* For #10734,alter the logic of exception handle in filter

* For #10734,fix code style

* dump change check task submit (#10755)

* dump change check task submit

* delete config nid convert error fix

* fix test case

* checkstyle

* Refactor grpc tls (#10759)

* Move Tls negotiator to GrpcSdkServer.

* use protocol negotiator builder replace directly create.

* use SPI load negotiator and set tls as default negotiator.

* Remove tlsconfig in BaseRpcServer.

* Add some ut.

* For checkstyle.

* fix word spelling in `AuthenticationManagerDelegator` (#10777)

* fix(#10427): When the execution of handleServerRequest() encounters an exception, record the log and throw an exception, then quickly response to the server errResponse (#10770)

* fix(#10585): selectInstances and selectOneHealthyInstance methods, if the parameter subscribe is true. Subscription is required when clientProxy.isSubscribe() is false. (#10805)

* disable check port input when use registered port (#10799)

* Add the handle to overload connection (#10783)

* add the handle to overload connection

* fast return

* [ISSUE #10662]Prometheus-sd add namespace and service api (#10663)

* add apis

* add tests

* fix checkstyle

* param namespace to namespaceId

* namespace to namespaceId

* fix test case

* fix test case

* Service instance should display related color when healthy or unhealthy (#10811)

* fix a couple of invaild props (#10810)

* feat(#10539): When the operation configuration fails, log. (#10804)

* [ISSUE #10744]feat:Add HealthControllerV2 and HealthControllerV2Test (#10786)

* [ISSUE #10744]feat:Add HealthControllerV2 and HealthControllerV2Test

* fix:V2 api return Result

* [ISSUE #10734] Refactor the ParamChecker and ParamExtractor (#10775)

* For #10734,refactor the paramextractor and ParamChecker

* For #10734,alter the rules of ParamCheck

* For #10734,alter the rules of ParamCheck

* For #10734,fix bug

* For #10734,fix bug and alter the ParamCheckRules.java

* For #10734,fix code style

* For #10734,fix the param check rules

* For #10734,implement the server param check config

* For #10734,optimize the logic

* For #10734,optimize the logic

* For #10734,optimize the logic

* Refactor Prometheus Module (#10827)

* Refactor Prometheus Module

* Complete Test Case

* format

* format

* For #10734,fix the param check rule (#10826)

* [ISSUE #10792]When nacos client use endpoint, the registration center should support configuring context-path and cluster-name like the configuration center (#10793)

* Reactor code in datasource-plugin (#10791)

* Reactor code in datasource-plugin

* Fix Abstract Mapper Test Case

* Add Empty Check

* Fix Checkstyle

* fix checkstyle

* fix check style

* fix check style

* Fix CheckStyle

* Fix SQL Blank

* bugfix for PersistentClientOperationServiceImpl log (#10825)

* For #10734,fix the param check rule (#10858)

* fix(#10831): When using the deregisterInstance method to remove one of multiple instances registered by batchRegisterInstance, all instances registered by batchRegisterInstance will be removed. (#10836)

* UnsupportedFeatureError (#10860)

* fix(distro): fix issue#10880. (#10881)

* feat(#5608 && #10223): When the custom instance id is empty, the id will be automatically generated. (#10812)

* fix: test-code branch (#10904)

* add nacos ci

* delete client version of nacos ci

* fix: test-code branch

* console-ui 新增 toml 语言支持,修复之前 properties 主题未生效的问题 (#10896)

* console-ui 新增 toml 语言支持,修复之前 properties 主题未生效的问题

* console-ui 新增 toml 语言支持,修复之前 properties 主题未生效的问题

* 老规矩,要编译一波

* feat(10891): Provide a configuration item for the maximum number of push retries, instead of directly hardcoding it to 50 times in the code. (#10895)

* [ISSUE #10824] Remove udp port param for v1-client (#10914)

* Remove UDP Param

* Fix gRPC client

* fix test case

* fix test case

* fix test case

* fix test case

* Fix login failed when close auth.

---------

Co-authored-by: Sunrisea <49605583+Sunrisea@users.noreply.github.com>
Co-authored-by: nov.lzf <liuzunfei@gmail.com>
Co-authored-by: 杨翊 SionYang <xiweng.yy@alibaba-inc.com>
Co-authored-by: ZhangShenao <15201440436@163.com>
Co-authored-by: blake.qiu <46370663+Bo-Qiu@users.noreply.github.com>
Co-authored-by: Joey777210 <53630996+Joey777210@users.noreply.github.com>
Co-authored-by: chenyiqin <83362909+Daydreamer-ia@users.noreply.github.com>
Co-authored-by: maoling <11016631+maoling@users.noreply.github.com>
Co-authored-by: DiligenceLai <96920907+DiligenceLai@users.noreply.github.com>
Co-authored-by: huhongjie2014 <139250842+huhongjie2014@users.noreply.github.com>
Co-authored-by: lu-xiaoshuang <121755080+lu-xiaoshuang@users.noreply.github.com>
Co-authored-by: zt9788 <zt9788@users.noreply.github.com>
Co-authored-by: 阿魁 <670569467@qq.com>
Co-authored-by: wuyfee <30968107+Wuyunfan-BUPT@users.noreply.github.com>
Co-authored-by: Darren Luo <jn296@qq.com>
Co-authored-by: xxc <xchaos8@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK contribution welcome kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants