Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define different values for NODE_INFO_ERROR,NODE_DOWN_FAILURE #11718

Closed
easynet-cn opened this issue Jan 31, 2024 · 2 comments
Closed

Define different values for NODE_INFO_ERROR,NODE_DOWN_FAILURE #11718

easynet-cn opened this issue Jan 31, 2024 · 2 comments
Labels
kind/bug Category issues or prs related to bug.
Milestone
2.3.1

Comments

@easynet-cn
Copy link
Contributor

Describe the bug
NODE_INFO_ERROR,NODE_DOWN_FAILURE have the same code "23001" in com.alibaba.nacos.api.model.v2.ErrorCode

Expected behavior
Define different values for NODE_INFO_ERROR,NODE_DOWN_FAILURE

Actually behavior

How to Reproduce

Desktop (please complete the following information):
Default branch

Additional context
@KomachiSion
Copy link
Collaborator

welcome PR

@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Feb 2, 2024
@KomachiSion KomachiSion added this to the 2.3.1 milestone Feb 2, 2024
@easynet-cn
Copy link
Contributor Author

@i will solve it@

easynet-cn added a commit to easynet-cn/nacos that referenced this issue Feb 17, 2024
@easynet-cn
[ISSUE alibaba#11718] Fix ErrorCode have the same code
38b8d06
@easynet-cn easynet-cn mentioned this issue Feb 17, 2024
Merged
KomachiSion pushed a commit that referenced this issue Feb 20, 2024
@easynet-cn
[ISSUE #11718] Fix ErrorCode have the same code (#11747)
1d3f1bb 
* [ISSUE #11718] Fix ErrorCode have the same code

* Fix code style.
huangkemingyyds pushed a commit to huangkemingyyds/nacos that referenced this issue Feb 20, 2024
@easynet-cn @huangkemingyyds
[ISSUE alibaba#11718] Fix ErrorCode have the same code (alibaba#11747)
2a8ea81 
* [ISSUE alibaba#11718] Fix ErrorCode have the same code

* Fix code style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
2.3.1
Development

No branches or pull requests
2 participants
@easynet-cn @KomachiSion