Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beatInfo的信息会覆盖已修改的数据。 #2800

Closed
horizonzy opened this issue May 14, 2020 · 0 comments · Fixed by #3037
Closed

beatInfo的信息会覆盖已修改的数据。 #2800

horizonzy opened this issue May 14, 2020 · 0 comments · Fixed by #3037
Assignees
@horizonzy
Labels
area/Naming
Milestone
1.3.1

Comments

@horizonzy
Copy link
Collaborator

Issue Description

Type: bug report

Describe what happened (or what feature you want)

通过OpenAPI对instance进行更新后，客户端感知到了服务端对instance的更新，没有去更新beatInfo中的信息。在客户端和服务端发生网络分区后，服务端感知不到客户端的心跳，把instance进行删除。后续网络恢复，客户端重新和服务端进行心跳连接，客户端的beatInfo还是之前的信息，会导致OpenAPI的更新被覆盖。
horizonzy added a commit to horizonzy/nacos that referenced this issue May 14, 2020
@horizonzy
fix-alibaba#2800.update the beatinfo when received server's instance …
f8aefca 
…change notify.
horizonzy added a commit to horizonzy/nacos that referenced this issue May 14, 2020
@horizonzy
fix-alibaba#2800.update the beatinfo when received server's instance …
becc101 
…change notify.
@horizonzy horizonzy mentioned this issue May 14, 2020
Closed
@chuntaojun chuntaojun mentioned this issue May 17, 2020
Closed
5 tasks
@yanlinly yanlinly added this to the 1.3.0 milestone May 17, 2020
horizonzy added a commit to horizonzy/nacos that referenced this issue May 18, 2020
@horizonzy
fix-alibaba#2800.update beatinfo when received instance modify info
dceb73b
@horizonzy horizonzy mentioned this issue May 18, 2020
Closed
@KomachiSion KomachiSion modified the milestones: 1.3.0, 1.3.1 Jun 10, 2020
horizonzy added a commit to horizonzy/nacos that referenced this issue Jun 11, 2020
@horizonzy
Merge branch 'develop' into fix-alibaba#2800
699e918
horizonzy added a commit to horizonzy/nacos that referenced this issue Jun 11, 2020
@horizonzy
Merge branch 'develop' into fix-alibaba#2800
9f4b22d 
# Conflicts:
#	client/src/main/java/com/alibaba/nacos/client/naming/NacosNamingService.java
horizonzy added a commit to horizonzy/nacos that referenced this issue Jun 11, 2020
@horizonzy
Merge remote-tracking branch 'origin/fix-#2800' into fix-alibaba#2800
3a82c35 
# Conflicts:
#	client/src/main/java/com/alibaba/nacos/client/naming/NacosNamingService.java
@horizonzy horizonzy mentioned this issue Jun 11, 2020
Merged
@KomachiSion KomachiSion linked a pull request Jun 12, 2020 that will close this issue
[ISSUE #2800] update beatinfo when received instance modify info #3037
Merged
KomachiSion added a commit that referenced this issue Jun 12, 2020
@KomachiSion
Merge pull request #3037 from horizonzy/fix-2800
c6d9426 
[ISSUE #2800] update beatinfo when received instance modify info
@horizonzy horizonzy mentioned this issue Oct 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@horizonzy horizonzy

Labels
area/Naming
Projects
None yet
Milestone
1.3.1
Development

Successfully merging a pull request may close this issue.

[ISSUE #2800] update beatinfo when received instance modify info horizonzy/nacos
3 participants
@yanlinly @horizonzy @KomachiSion