Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified code style file to do format verification and formatting #2992

Closed
KomachiSion opened this issue Jun 8, 2020 · 4 comments · Fixed by #3293
Closed

Unified code style file to do format verification and formatting #2992

KomachiSion opened this issue Jun 8, 2020 · 4 comments · Fixed by #3293
Assignees
@KomachiSion
Labels
kind/code quality status/need discuss
Milestone
1.3.1

Comments

@KomachiSion
Copy link
Collaborator

Issue Description

Type: feature request

Describe what you expected to happen

I hope to add a unified checkstyle file, and then use this file for format verification and formatting.

So I want to open a discussion to choose one checkstyle file:

  1. google checkstyle
  2. spring boot checkstyle
  3. modify from other checkstyle
  4. other
@KomachiSion KomachiSion added this to the 1.3.1 milestone Jun 8, 2020
@zongtanghu
Copy link
Collaborator

I think google code checkstyple may be better choice.

@jzdayz
Copy link
Contributor

jzdayz commented Jun 9, 2020

google checkstyle

@KomachiSion
Copy link
Collaborator Author

From the discussion in issue and meeting at 2020.06.11. We prefer to use google style as based, and change some setting like line warp , indent and so on.

I will create nacosCodeStyle.xml file, init format for all code, and write a document in nacos.io to lead developers.

BTW, the Alibaba Java Coding Guidelines will also be used.

@KomachiSion KomachiSion self-assigned this Jun 15, 2020
This was referenced Jun 16, 2020
Merged
Merged
chuntaojun added a commit that referenced this issue Jun 17, 2020
@chuntaojun
Merge pull request #3088 from KomachiSion/develop-issue#2992
3f401c9 
[ISSUE #2992] Add text import guide in codeStyle.md to enhance code style import
@KomachiSion KomachiSion mentioned this issue Jun 17, 2020
Merged
5 tasks
chuntaojun pushed a commit that referenced this issue Jun 17, 2020
@KomachiSion
[ISSUE #2992] Use new code style for nacos-naming (#3090)
67829bb 
* Update check style to ignore spring bean java doc

* use new code style for nacos-naming
This was referenced Jun 18, 2020
Merged
Closed
@chuntaojun chuntaojun mentioned this issue Jun 18, 2020
Merged
5 tasks
chuntaojun pushed a commit that referenced this issue Jun 18, 2020
@KomachiSion
[ISSUE #2992] use new code style for nacos-common (#3106)
f864880 
* use new code style for nacos-common

* Fix code style file can't set java import problem.
@KomachiSion KomachiSion mentioned this issue Jun 18, 2020
Merged
5 tasks
@KomachiSion
Copy link
Collaborator Author

KomachiSion commented Jun 28, 2020 •
edited
Loading

reformat task:

This was referenced Jun 28, 2020
Merged
Merged
Merged
Merged
@zongtanghu zongtanghu mentioned this issue Jul 3, 2020
Closed
@KomachiSion KomachiSion mentioned this issue Jul 3, 2020
Merged
5 tasks
@zongtanghu zongtanghu mentioned this issue Jul 3, 2020
Merged
5 tasks
yanlinly pushed a commit that referenced this issue Jul 3, 2020
@KomachiSion
[ISSUE #2992] Use new code style for nacos-client module. (#3219)
1a0df78 
* Use new code style for nacos-client module.

* For checkstyle
yanlinly pushed a commit that referenced this issue Jul 3, 2020
@KomachiSion
[ISSUE #2992] Use new code style for nacos-address module. (#3239)
8c9622f 
* reformat with new code style for nacos-address

* Use new code style for nacos-address module.
@zongtanghu zongtanghu mentioned this issue Jul 4, 2020
Closed
@wangweizZZ wangweizZZ mentioned this issue Jul 5, 2020
Merged
5 tasks
@KomachiSion KomachiSion mentioned this issue Jul 9, 2020
Merged
5 tasks
chuntaojun pushed a commit that referenced this issue Jul 9, 2020
@KomachiSion
[ISSUE #2992] Use new code style for nacos-cmdb module. (#3289)
bc9861c 
* Use new code style for nacos-cmdb module.

* Check again for nacos-common module.

* Check again for nacos-core module.

* Check again for nacos-naming module.

* skip nacos-test in checkstyle
@KomachiSion KomachiSion mentioned this issue Jul 10, 2020
Merged
5 tasks
@KomachiSion KomachiSion linked a pull request Jul 10, 2020 that will close this issue
[ISSUE #2992]Recheck all checkstyle and open checkstyle during building #3293
Merged
5 tasks
yanlinly pushed a commit that referenced this issue Jul 10, 2020
@KomachiSion
[ISSUE #2992]Recheck all checkstyle and open checkstyle during buildi…
95f3bfb 
…ng (#3293)

* Re-check code style for nacos-config module.

* Re-check code style for other module.

* Open checkstyle plugin check during build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KomachiSion KomachiSion

Labels
kind/code quality status/need discuss
Projects
None yet
Milestone
1.3.1
Development

Successfully merging a pull request may close this issue.

[ISSUE #2992]Recheck all checkstyle and open checkstyle during building KomachiSion/nacos
3 participants
@zongtanghu @jzdayz @KomachiSion