Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sink the Notify implementation into common module and optimize some parts. #3117

Closed
zongtanghu opened this issue Jun 19, 2020 · 1 comment
Closed

Comments

@zongtanghu
Copy link
Collaborator

Issue Description

Type: feature request

Describe what happened (or what feature you want)

(1)Sink the Notify implementation into common module and optimize some parts.

And this pr is one part of another bigger pr.The link is #2859.

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

Anything else we need to know?

zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 19, 2020
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 19, 2020
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 19, 2020
chuntaojun pushed a commit that referenced this issue Jun 21, 2020
…imize some parts (#3118)

* [#3117]Sink the Notify implementation into common module and optimize some parts.

* [#3117]fix typo and reformat code styles.

* [#3117]fix typo and reformat code styles.

* [#3118]fix typo and formate.

* [#3118]Unify Subsciber and SmartSubscriber, and fix some typo and reformat.

* [#3118]fix some typo and reformat.
@zongtanghu
Copy link
Collaborator Author

This issue's pr has already been merged, so this issue need to be close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants