Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nacos console Service list .Group search is not correct #4306

Closed
woxiangwoxiangxiang opened this issue Nov 23, 2020 · 5 comments
Closed

Nacos console Service list .Group search is not correct #4306

woxiangwoxiangxiang opened this issue Nov 23, 2020 · 5 comments
Labels
kind/bug Category issues or prs related to bug.
Milestone
1.4.2

Comments

@woxiangwoxiangxiang
Copy link

Nacos console Service list .Group search is not correct.
WeChatf4c28205f9159b7be6b47a9123b47cff
I searched for 'Gateway' in 'group name' . There is no 'group name' with the name 'Gateway' in my data. But he was able to query the data.
@horizonzy
Copy link
Collaborator

Maybe this search request occur error, now when the search service request without serviceName, it will error.
Can you press F12 to open console, check the network console, view the response.

@woxiangwoxiangxiang
Copy link
Author

This is the requested Network Console.

WeChate02cbb06139fe6f099a0c44582737471

WeChat9c01b0b6d2c5bfac844c8f908e13d4a1

Request parameters are ok. Is the server side of the query logic is not correct, is a server side of the bug.

@horizonzy
Copy link
Collaborator

I check it, it's really bug. it's the server side problem.

@woxiangwoxiangxiang
Copy link
Author

I can fix it

@horizonzy
Copy link
Collaborator

yes, recent pr #4308 modify it, you should based on it to fix this bug.

woxiangwoxiangxiang pushed a commit to woxiangwoxiangxiang/nacos that referenced this issue Nov 24, 2020
Nacos console Service list .Group search is not correct alibaba#4306
92523de
This was referenced Nov 24, 2020
Closed
Closed
@KomachiSion KomachiSion added this to the 1.4.1 milestone Nov 27, 2020
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. and removed kind/research labels Dec 23, 2020
@KomachiSion KomachiSion modified the milestones: 1.4.1, 1.4.2 Jan 13, 2021
@horizonzy horizonzy mentioned this issue Mar 5, 2021
Merged
KomachiSion pushed a commit that referenced this issue Mar 8, 2021
@horizonzy
[ISSUE-#4306] StringJoiner should consider '@@'. (#5022)
b1c39a6 
* StringJoiner should consider '@@'.

* StringJoiner should consider '@@'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
1.4.2
3 participants
@horizonzy @woxiangwoxiangxiang @KomachiSion