-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Nacos console Service list .Group search is not correct #4306 #4319
Conversation
wangchunhao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Please append some unit test cases to prove your changes |
@woxiangwoxiangxiang Please sign the Contributor License Agreement first. |
You need to verify the split is correct through unit tests |
@@ -923,7 +923,7 @@ public int getInstanceCount() { | |||
} | |||
return total; | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not change the indentation. Maybe you do not use nacos code style. Can you read the style/codeStyle.md in source code directory?
@woxiangwoxiangxiang Please fix code style problem and sign CLA, otherwise we will close this PR. |
@woxiangwoxiangxiang Sorry, your CLA still not right, I see the true commit user is BTW, we strongly recommend you use the nacos code style when you change nacos codes. |
Fix #4306