Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nacos console Service list .Group search is not correct #4306 #4319

Closed

Conversation

woxiangwoxiangxiang
Copy link

Fix #4306

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wangchunhao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paderlol
Copy link
Collaborator

Please append some unit test cases to prove your changes

@Maijh97
Copy link
Collaborator

Maijh97 commented Nov 25, 2020

@woxiangwoxiangxiang Please sign the Contributor License Agreement first.

@woxiangwoxiangxiang
Copy link
Author

woxiangwoxiangxiang commented Nov 25, 2020

Please append some unit test cases to prove your changes

Where do I add unit tests? In ServiceManagerTest?

But ServiceManagerTest doesn't run correctly.
WeChat459ff5a1fea75c6664dd9c5adb9eb531
This is the result of the original ServiceManagerTest run

@paderlol
Copy link
Collaborator

You need to verify the split is correct through unit tests

@@ -923,7 +923,7 @@ public int getInstanceCount() {
}
return total;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change the indentation. Maybe you do not use nacos code style. Can you read the style/codeStyle.md in source code directory?

@KomachiSion
Copy link
Collaborator

Please append some unit test cases to prove your changes

Where do I add unit tests? In ServiceManagerTest?

But ServiceManagerTest doesn't run correctly.
WeChat459ff5a1fea75c6664dd9c5adb9eb531
This is the result of the original ServiceManagerTest run

Why you need spy to create ServiceManager?

@KomachiSion
Copy link
Collaborator

@woxiangwoxiangxiang Please fix code style problem and sign CLA, otherwise we will close this PR.

@KomachiSion
Copy link
Collaborator

@woxiangwoxiangxiang Sorry, your CLA still not right, I see the true commit user is wangchunhao not your github id.
So you should use git config user.name and git config user.email to re-commit your change and re-submit a PR to fix it.

BTW, we strongly recommend you use the nacos code style when you change nacos codes.

@KomachiSion KomachiSion closed this Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nacos console Service list .Group search is not correct
5 participants