Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assert instead of System.out #5380

Closed
SunJiFengPlus opened this issue Apr 15, 2021 · 5 comments
Closed

Use assert instead of System.out #5380

SunJiFengPlus opened this issue Apr 15, 2021 · 5 comments

Comments

@SunJiFengPlus
Copy link
Contributor

图片

Please assign it to me, I'd love to do it

@KomachiSion
Copy link
Collaborator

Thanks for your contribution.
But I see your provided picture, all most of them are just want to show test detail rather than assert case.

So I think there is no need to change them to assert.

@SunJiFengPlus
Copy link
Contributor Author

not as much as in the picture, just a few points.

图片
图片
图片

@KomachiSion
Copy link
Collaborator

Yes, we need to discuss whether these case is need be assert or just a print dependency

@SunJiFengPlus
Copy link
Contributor Author

图片
图片
图片

I think there are three System.out need to replace it with assert, and if confirmed, I'll start.

@KomachiSion
Copy link
Collaborator

go ahead please, these case should add assert to ensure.

KomachiSion pushed a commit that referenced this issue Apr 25, 2021
* use assert instead of System.out

* move test case, there is no file named ParamCheckUtil.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants