Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

127.100.19 is a legal ip #5390

Closed
SunJiFengPlus opened this issue Apr 17, 2021 · 0 comments
Closed

127.100.19 is a legal ip #5390

SunJiFengPlus opened this issue Apr 17, 2021 · 0 comments
Assignees
@KeRan213539
Labels
kind/bug Category issues or prs related to bug.
Milestone
1.4.2

Comments

@SunJiFengPlus
Copy link
Contributor

Describe the bug
Assert.assertFalse(IPUtil.isIPv4("127.100.19"));
This unit test case not pass.

Expected behavior
ut pass

Additional context
图片

Please assign it to me, I'd love to do it.
SunJiFengPlus pushed a commit to SunJiFengPlus/nacos that referenced this issue Apr 17, 2021
fix alibaba#5390
ba2cca3
@KeRan213539 KeRan213539 mentioned this issue Apr 19, 2021
Merged
@KomachiSion KomachiSion reopened this Apr 19, 2021
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. and removed kind/research labels Apr 19, 2021
@KomachiSion KomachiSion added this to the 1.4.2 milestone Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KeRan213539 KeRan213539

Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
1.4.2
Development

No branches or pull requests
3 participants
@KeRan213539 @KomachiSion @SunJiFengPlus