Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The class com.alibaba.nacos.naming.consistency.persistent.PersistentConsistencyServiceDelegateImpl lacks a lot of Unit tests (Both in Nacos1.4.1 and 2.0.0) #5418

Closed
realJackSun opened this issue Apr 20, 2021 · 3 comments · Fixed by #5491
Closed

The class com.alibaba.nacos.naming.consistency.persistent.PersistentConsistencyServiceDelegateImpl lacks a lot of Unit tests (Both in Nacos1.4.1 and 2.0.0) #5418

realJackSun opened this issue Apr 20, 2021 · 3 comments · Fixed by #5491
Assignees
@li-xiao-shuang
Labels
area/Test
Milestone
1.4.2

Comments

@realJackSun
Copy link
Collaborator

The class com.alibaba.nacos.naming.consistency.persistent.PersistentConsistencyServiceDelegateImpl lacks a lot of Unit tests (Both in Nacos1.4.1 and 2.0.0), could you provide?
@li-xiao-shuang
Copy link
Collaborator

@i will solve it@

@KomachiSion
Copy link
Collaborator

Only submit to develop branch is ok. we can merge it to 2.0.X

@KomachiSion KomachiSion added this to the 1.4.2 milestone Apr 21, 2021
@li-xiao-shuang li-xiao-shuang mentioned this issue Apr 25, 2021
Merged
5 tasks
@li-xiao-shuang
Copy link
Collaborator

Only submit to develop branch is ok. we can merge it to 2.0.X
ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@li-xiao-shuang li-xiao-shuang

Labels
area/Test
Projects
None yet
Milestone
1.4.2
Development

Successfully merging a pull request may close this issue.

add unit test for PersistentConsistencyServiceDelegateImpl li-xiao-shuang/nacos
3 participants
@li-xiao-shuang @KomachiSion @realJackSun