Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nacos 2.0.3] add client info for OperatorController metrics interface #6572

Closed
MajorHe1 opened this issue Aug 5, 2021 · 0 comments · Fixed by #6576
Closed

[nacos 2.0.3] add client info for OperatorController metrics interface #6572

MajorHe1 opened this issue Aug 5, 2021 · 0 comments · Fixed by #6576
Labels
kind/enhancement Category issues or prs related to enhancement.
Milestone
2.0.4

Comments

@MajorHe1
Copy link
Collaborator

MajorHe1 commented Aug 5, 2021

image
There are only service and instance info in OperatorController metrics interface.
However, if nacos server run in 2.X mode, and all the clients use nacos-client 2.X, the field responsibleServiceCount and responsibleInstanceCount is always zero.
So I want to add client info for this interface, include :
image
After this change, we can get client info from this interface.
For example, if we want to shutdown nacos-server gracefully, all the client should switch to other nacos-server node at first, and the filed responsibleClientCount will be zero. After that we can safely shutdown this server.
MajorHe1 added a commit to MajorHe1/nacos that referenced this issue Aug 5, 2021
@MajorHe1
[ISSUE alibaba#6572] add client info for OperatorController metrics i…
0e28ea5 
…nterface
@MajorHe1 MajorHe1 mentioned this issue Aug 5, 2021
Merged
5 tasks
MajorHe1 added a commit to MajorHe1/nacos that referenced this issue Aug 6, 2021
@MajorHe1
[ISSUE alibaba#6572] move PERSISTENT_SUFFIX to ClientConstants
59c3453
@realJackSun realJackSun added the kind/enhancement Category issues or prs related to enhancement. label Aug 7, 2021
KomachiSion pushed a commit that referenced this issue Aug 9, 2021
@MajorHe1
[ISSUE #6572] add client info for OperatorController metrics interface (
0b15090 
#6576)

* [ISSUE #6572] add client info for OperatorController metrics interface

* [ISSUE #6572] move PERSISTENT_SUFFIX to ClientConstants
@KomachiSion KomachiSion added this to the 2.1.0 milestone Aug 9, 2021
@MajorHe1 MajorHe1 mentioned this issue Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
2.0.4
Development

Successfully merging a pull request may close this issue.

[ISSUE #6572] add client info for OperatorController metrics interface MajorHe1/nacos
3 participants
@KomachiSion @MajorHe1 @realJackSun