[ISSUE #6572] add client info for OperatorController metrics interface #6576
Conversation
| @@ -105,7 +103,7 @@ private ClientManager getClientManagerById(String clientId) { | |||
| if (isConnectionBasedClient(clientId)) { | |||
| return connectionBasedClientManager; | |||
| } | |||
| return clientId.endsWith(SUFFIX) ? persistentIpPortClientManager : ephemeralIpPortClientManager; | |||
| return clientId.endsWith(IpPortBasedClient.PERSISTENT_SUFFIX) ? persistentIpPortClientManager : ephemeralIpPortClientManager; | |||
There was a problem hiding this comment.
No need to move SUFFIX to IpPortBasedClient
There was a problem hiding this comment.
If we don't move SUFFIX to IpPortBasedClient, we should declare another variable named SUFFIX in OperatorController to judge whether clientId is persistent clientId.
So I think PERSISTENT_SUFFIX is a property of IpPortBasedClient.
Otherwise, we should change SUFFIX from private to public, in order that OperatorController can reference it.
There was a problem hiding this comment.
Can we move it to ClientConstants?
There was a problem hiding this comment.
And replace all false with same meaning usage.
There was a problem hiding this comment.
Move it to ClientConstants is a good choice.
It seems that persistent clientId judgement is only occurs in ClientManagerDelegate and OperatorController so far.
There was a problem hiding this comment.
Should we move ID_DELIMITER from IpPortBasedClient to ClientConstants too?
KomachiSion
added
the
kind/enhancement
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
fix #6572
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.