Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nacos-config findAllConfigInfoForDumpAll method bug #8318

Closed
dph5199278 opened this issue May 8, 2022 · 1 comment · Fixed by #8319
Closed

nacos-config findAllConfigInfoForDumpAll method bug #8318

dph5199278 opened this issue May 8, 2022 · 1 comment · Fixed by #8319
Labels
area/Config kind/bug Category issues or prs related to bug.

Comments

@dph5199278
Copy link

Describe the bug
In there have sql parameters bug.

ExternalStoragePersistServiceImpl#findAllConfigInfoForDumpAll
image

EmbeddedStoragePersistServiceImpl#findAllConfigInfoForDumpAll
image

Expected behavior
return Page Object.

Acutally behavior
SQL Error

Desktop (please complete the following information):

  • Version [2.1.0]
  • Module [nacos-config]

Resolvent
Maybe

ExternalStoragePersistServiceImpl#findAllConfigInfoForDumpAll
new Object[] {(pageNo - 1) * pageSize, pageSize} instead of params.toArray()

EmbeddedStoragePersistServiceImpl#findAllConfigInfoForDumpAll
new Object[] {(pageNo - 1) * pageSize, pageSize} instead of EMPTY_ARRAY

Thanks.
@onewe
Copy link
Collaborator

onewe commented May 9, 2022

I'm going to test it at once.

onewe added a commit to onewe/nacos that referenced this issue May 9, 2022
@onewe
[ISSUE alibaba#8318] fix findAllConfigInfoForDumpAll sql args error
fe1775d 
Close alibaba#8318
@onewe onewe mentioned this issue May 9, 2022
Merged
5 tasks
@KomachiSion KomachiSion added area/Config kind/bug Category issues or prs related to bug. labels May 9, 2022
onewe added a commit to onewe/nacos that referenced this issue May 9, 2022
@onewe
[ISSUE alibaba#8318] remove the unnecessary arg
10134d6 
Close alibaba#8318
KomachiSion pushed a commit that referenced this issue May 13, 2022
@onewe
[ISSUE #8318] fix findAllConfigInfoForDumpAll sql args error (#8319)
eff327d 
* [ISSUE #8318] fix findAllConfigInfoForDumpAll sql args error

Close #8318

* [ISSUE #8318] remove the unnecessary arg

Close #8318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/Config kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #8318] fix findAllConfigInfoForDumpAll sql args error onewe/nacos
3 participants
@dph5199278 @KomachiSion @onewe