Remove disable "UseParNewGC" option when use CMS #10631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is conflict for your PR, please fix them first |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #10631 +/- ##
=============================================
- Coverage 53.68% 53.65% -0.03%
+ Complexity 5510 5504 -6
=============================================
Files 897 897
Lines 28812 28812
Branches 3162 3162
=============================================
- Hits 15468 15460 -8
- Misses 11994 11999 +5
- Partials 1350 1353 +3 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
KomachiSion
approved these changes
Jun 15, 2023
KomachiSion
added
kind/code quality
and removed
pending
wukong121
pushed a commit
to wukong121/nacos
that referenced
this pull request
Aug 4, 2023
* Specify the GC as the CMS when jdk version less 9. * Remove disable "UseParNewGC" when use CMS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
In this change Specify the GC as the CMS when jdk version less 9, I just restored the earlier code,but I didn't look closely at whether it was a plus or a minus before "UseParNewGC", @iJIAJIA points out the problem.
Brief changelog
Specify the GC as the CMS when jdk version less than 9.