Refactor dispatch task execute #3995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuntaojun
reviewed
Oct 15, 2020
| */ | ||
| public class NacosExecuteTaskExecuteEngine extends AbstractNacosTaskExecuteEngine<AbstractExecuteTask> { | ||
|
|
||
| private final TaskExecuteWorker[] executeWorkers; |
There was a problem hiding this comment.
Can it be dynamically changed or defined by the user
| } | ||
| } | ||
|
|
||
| private int findWorkerCount() { |
There was a problem hiding this comment.
If I remember correctly, there's a special way to do this
There was a problem hiding this comment.
How to do this?
There was a problem hiding this comment.
com.alibaba.nacos.common.utils.ThreadUtils#getSuitableThreadCount
common/src/main/java/com/alibaba/nacos/common/task/engine/TaskExecuteWorker.java
Show resolved
Hide resolved
chuntaojun
approved these changes
Oct 16, 2020
zilongTong
pushed a commit
to zilongTong/nacos
that referenced
this pull request
Oct 19, 2020
* Refactor nacos task execute engine * Refactor nacos task execute engine * For checkstyle * For checkstyle * Use ThreadUtils to reduce duplicate codes * Set custom logger for TaskExecuteWorker * Set custom logger for TaskExecuteWorker
WesleyOne
pushed a commit
to WesleyOne/nacos
that referenced
this pull request
Oct 20, 2020
* Refactor nacos task execute engine * Refactor nacos task execute engine * For checkstyle * For checkstyle * Use ThreadUtils to reduce duplicate codes * Set custom logger for TaskExecuteWorker * Set custom logger for TaskExecuteWorker
loveincode
added a commit
to Framework-Source-Code/nacos
that referenced
this pull request
Oct 21, 2020
* 'develop' of github.com:alibaba/nacos: (678 commits) Fix integration test error Fix unit test error in ci For checkStyle Modify the startup script custom configuration first default configuration (alibaba#4021) Revert "Naming module Raft protocol migration" [ISSUE alibaba#3904] feature - operate instance's metadata alonely (alibaba#3912) For alibaba#3710#, Fix special characters cannot be used in Metadata (alibaba#4019) [ISSUE-alibaba#3855] Provided a feature to view version comparisons in the configDetails page (alibaba#3988) Refactor dispatch task execute (alibaba#3995) Revert "for alibaba#3621 (alibaba#3668)" (alibaba#3999) Naming module Raft protocol migration (alibaba#3989) refactor: code refactor [ISSUE alibaba#3576] [Enhancement] Adding the destroy lifecycle method on NamingMaintainService (alibaba#3985) Fix issue 2866 (alibaba#3984) For alibaba#3384, Fix member extend info do not update error. (alibaba#3982) Fix#3973 (alibaba#3974) Move remove listener logic to ServiceManager Move remove listener logic to ServiceManager 1.fix unit test can't pass (alibaba#3956) [ISSUE alibaba#3909] add domain's judgement (alibaba#3913) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
Refactor dispatch task execute, abstract an execute task engine to common-module, so that it can be used only only in distro.
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.