Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3102] Create utils class to nacos-common #4165

Merged
merged 2 commits into from Nov 9, 2020

Conversation

corey89757
Copy link
Contributor

What is the purpose of the change

#3102 phase 1.
Create utils class to nacos-common, prepare to remove apache commons-lang dependency step by step.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Change-Id: I30970371b86a032366bd66c7b031a4cc3085512e
…yle errors.

Change-Id: I4711ad2b64a4265379f5d7df7434352e69c3760d
@KomachiSion
Copy link
Collaborator

I need to check If we copy some method from lang/lang3 whether it violates.

@KomachiSion
Copy link
Collaborator

We can merge this PR first, and we need open a new PR to modified the copyright, comments and licence to describe we copy some method and modified from lang3.

@KomachiSion KomachiSion added the dependencies Pull requests that update a dependency file label Nov 9, 2020
@KomachiSion KomachiSion merged commit cf92d19 into alibaba:develop Nov 9, 2020
@KomachiSion KomachiSion added this to the 1.4.1 milestone Nov 9, 2020
KomachiSion added a commit that referenced this pull request Nov 10, 2020
KeRan213539 pushed a commit that referenced this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants