Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apache commons-lang3 dependency in Server. #3102

Closed
8 tasks done
KomachiSion opened this issue Jun 18, 2020 · 8 comments
Closed
8 tasks done

Remove apache commons-lang3 dependency in Server. #3102

KomachiSion opened this issue Jun 18, 2020 · 8 comments
Labels
contribution welcome dependencies Pull requests that update a dependency file kind/refactor
Milestone

Comments

@KomachiSion
Copy link
Collaborator

KomachiSion commented Jun 18, 2020

Issue Description

Type: Remove dependency

Describe what happened (or what feature you want)

Nacos wants to reduce the dependency to reduce size of server. And the community volunteers wants to remove commons-lang3 first. So I create an issue and split tasks for community.

Describe what you expected to happen

Replace commons-lang3 dependency module by module. And the behavior of server do not change.

How to reproduce it (as minimally and precisely as possible)

  • Create utils class to nacos-common or nacos-api module.
  • Replace commons-lang3 in nacos-common module.
  • Replace commons-lang3 in nacos-core module.
  • Replace commons-lang3 in nacos-config module.
  • Replace commons-lang3 in nacos-naming module.
  • Replace commons-lang3 in nacos-console module.
  • Replace commons-lang3 in other modules(if necessary, will be spiltted again).
  • remove commons-lang3 pom dependency.

Welcome volunteer join us.

@KomachiSion KomachiSion added contribution welcome dependencies Pull requests that update a dependency file labels Jun 18, 2020
@KomachiSion KomachiSion added this to the 1.4.0 milestone Jun 18, 2020
@zongtanghu
Copy link
Collaborator

zongtanghu commented Jun 18, 2020

[] Create utils class to nacos-common or nacos-core module.
[] Replace commons-lang3 in nacos-common module.
[] Replace commons-lang3 in nacos-core module.
[] Replace commons-lang3 in nacos-config module.
[] Replace commons-lang3 in nacos-naming module.
[] Replace commons-lang3 in nacos-console module.
[] Replace commons-lang3 in other modules(if necessary, will be spiltted again).
[] remove commons-lang3 pom dependency.

Then, we claim this feature issue? @KomachiSion

@KomachiSion
Copy link
Collaborator Author

KomachiSion commented Jun 18, 2020

@zongtanghu you can create an issue according these unfinished task. and refer to this issue.

Of course, you can also directly open PR to finished task one by one.

@wangweizZZ
Copy link
Collaborator

wangweizZZ commented Aug 24, 2020

@lin-mt @zongtanghu hi,is this part of work still in progress? Maybe @corey89757 can help solve this problem together :-)

@shizhengxing
Copy link
Contributor

shizhengxing commented Sep 19, 2020

I‘d like to work this out together

@corey89757
Copy link
Contributor

corey89757 commented Nov 5, 2020

I am working on it.

corey89757 added a commit to corey89757/nacos that referenced this issue Nov 5, 2020
…mon.lang3 in api,client and common module.

Change-Id: I3a1d70f9e5ad8e2ce76868c8f2e6f954c0faad81
@corey89757
Copy link
Contributor

corey89757 commented Nov 6, 2020

I'll split the pr and optimise some details.

corey89757 added a commit to corey89757/nacos that referenced this issue Nov 7, 2020
Change-Id: I30970371b86a032366bd66c7b031a4cc3085512e
corey89757 added a commit to corey89757/nacos that referenced this issue Nov 7, 2020
…yle errors.

Change-Id: I4711ad2b64a4265379f5d7df7434352e69c3760d
KomachiSion pushed a commit that referenced this issue Nov 9, 2020
* [ISSUE #3102] Create utils class to nacos-common.

Change-Id: I30970371b86a032366bd66c7b031a4cc3085512e

* [ISSUE #3102] Create utils class to nacos-common, fix check style errors.

Change-Id: I4711ad2b64a4265379f5d7df7434352e69c3760d
KomachiSion added a commit that referenced this issue Nov 10, 2020
KeRan213539 pushed a commit that referenced this issue Nov 10, 2020
corey89757 pushed a commit to corey89757/nacos that referenced this issue Nov 11, 2020
…prepare to remove lang/lang3 dependency in common/api/client.

Change-Id: I7c7d39991b97be9c505a66ce013de0166487e74b
corey89757 pushed a commit to corey89757/nacos that referenced this issue Nov 11, 2020
…prepare to remove lang/lang3 dependency in common/api/client.

Change-Id: If4f1f5b0c591862b7ebdcee5b61cd740299c3a40
KomachiSion pushed a commit that referenced this issue Nov 11, 2020
* add commons-lang3 dependency into core and sys, prepare to remove lang/lang3 dependency in common/api/client.

Change-Id: I4b7a0bec09359e64ecf997b123b85c265bfe16cf

* remove lang dependency.

Change-Id: I5cbd811babc8269a54b93e278ad6e5e2663c8427
KomachiSion pushed a commit that referenced this issue Nov 12, 2020
…4207)

* add commons-lang3 dependency into core and sys, prepare to remove lang/lang3 dependency in common/api/client.

Change-Id: I4b7a0bec09359e64ecf997b123b85c265bfe16cf

* remove lang dependency.

Change-Id: I5cbd811babc8269a54b93e278ad6e5e2663c8427

* remove lang/lang3 dependency from api/common/client.

Change-Id: I77b5cf5d922a7c031fa4676d1404de7cb255a010
@corey89757
Copy link
Contributor

corey89757 commented Nov 13, 2020

Since now, there isn't any lang dependency in common/api/client module.

@li-xiao-shuang
Copy link
Collaborator

li-xiao-shuang commented May 14, 2021

Has the problem been dealt with yet

zzq1314zll added a commit to zzq1314zll/nacos that referenced this issue Jun 28, 2021
zzq1314zll added a commit to zzq1314zll/nacos that referenced this issue Jun 28, 2021
@KomachiSion KomachiSion added this to the 2.0.3 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome dependencies Pull requests that update a dependency file kind/refactor
Projects
None yet
Development

No branches or pull requests

6 participants