Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sql injection bug #4245

Merged
merged 3 commits into from Nov 18, 2020
Merged

Fix sql injection bug #4245

merged 3 commits into from Nov 18, 2020

Conversation

@paderlol
Copy link
Collaborator

@paderlol paderlol commented Nov 17, 2020

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
@paderlol paderlol requested review from chuntaojun and KomachiSion Nov 17, 2020
@KomachiSion
Copy link
Collaborator

@KomachiSion KomachiSion commented Nov 17, 2020

CI failed, please solve check style problem

Loading

@paderlol
Copy link
Collaborator Author

@paderlol paderlol commented Nov 17, 2020

CI failed, please solve check style problem

I have solved

Loading

@KomachiSion KomachiSion added this to the 1.4.1 milestone Nov 18, 2020
@KomachiSion KomachiSion merged commit 501b1e7 into alibaba:develop Nov 18, 2020
2 checks passed
Loading
@KomachiSion KomachiSion mentioned this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants