Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4424] Fixed issue where null values could not be converted to base parameters #4527

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

neighbor-uncleWang
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

修复#4424

Brief changelog

当protectThreshold传入值为null时,给它设置一个默认值。

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2020

CLA assistant check
All committers have signed the CLA.

@neighbor-uncleWang neighbor-uncleWang changed the title Fixed issue where null values could not be converted to base parameters #4424 [ISSUE #4424] Fixed issue where null values could not be converted to base parameters Dec 20, 2020
@neighbor-uncleWang neighbor-uncleWang marked this pull request as ready for review December 20, 2020 08:47
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Dec 21, 2020
@KomachiSion KomachiSion added this to the 1.4.1 milestone Dec 21, 2020
@KomachiSion
Copy link
Collaborator

Thanks @neighbor-uncleWang . Looking forward to more contributions

@KomachiSion KomachiSion merged commit 2f50f53 into alibaba:develop Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants