Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5026]fix MetricsHttpAgent metrics twice #5029

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

shalk
Copy link
Contributor

@shalk shalk commented Mar 6, 2021

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #5026

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@shalk shalk changed the title fix MetricsHttpAgent metrics twice [#ISSUE 5026]fix MetricsHttpAgent metrics twice Mar 6, 2021
@shalk shalk changed the title [#ISSUE 5026]fix MetricsHttpAgent metrics twice [ISSUE #5026]fix MetricsHttpAgent metrics twice Mar 6, 2021
Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check the code of Histogram.Timer
the close method will call observeDuration.
your fix is ok. But I think use only close maybe better.
Beacuse close is an interface method but observeDuration is a class method.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check the PR again, and find that this PR is for Nacos1.X. In Nacos1.X, nacos-client is compile by 1.6 jdk. So use observeDuration is right.

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Mar 10, 2021
@KomachiSion KomachiSion added this to the 1.4.2 milestone Mar 10, 2021
@KomachiSion KomachiSion merged commit 3dd7915 into alibaba:develop Mar 10, 2021
@shalk shalk deleted the fix-metrics-http-agent-5026-1 branch March 10, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nacos.client.MetricsHttpAgent record one request twice
2 participants