[ISSUE #6906] Fix create NacosNamingService instance failure

[yuhaowin]

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fix when dependency high version logback, low version slf4j, create NacosNamingService instance failure。

For #6906

Brief changelog

change NacosLogging determine logger type method

Verifying this change

when dependency logback，but effective logger is another logger implementation，for instance log4j，able to create NacosLoggin instance.

Follow this checklist to help us incorporate your contribution quickly and easily:

• Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
• Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
• Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[KomachiSion]

Have you test the old version slf4j and logback can run well after your modified?

[yuhaowin]

Have you test the old version slf4j and logback can run well after your modified?

I don't konw how to test this with Junit, but i install it in my repository after modified, it's work for old version slf4j and logback.

[realJackSun]

Why did you remove this logic?

[yuhaowin]

Why did you remove this logic?

because nacos-client dependency log4j and logback, but actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory], and the binding is determined by the JVM, so when run mvn clean install -DskipITs , the method NacosLogging.getInstance().loadConfiguration() is executed in com.alibaba.nacos.client.utils.LogUtils, and
contextConfiguration.getLoggers().size() is more than one.

why it is work well before i modifed this issue? because effective logger is log4j, but determined logback, executed LogbackNacosLogging().loadConfiguration(), contextConfiguration.getLoggers().size() still zero.

[KomachiSion]

But CI can pass, which means the old implementation is correct.

If can't remove this logic can't pass this case after your changes. We need more consider your changes whether has problem.

[yuhaowin]

But CI can pass, which means the old implementation is correct.

If can't remove this logic can't pass this case after your changes. We need more consider your changes whether has problem.

ok, thanks for your reply, But I still think just executed Class.forName("ch.qos.logback.classic.Logger") whthout exception, determined current logger instance is logback, is not particularly appropriate.

[KomachiSion]

I think the PR provide a better one way to handle this problem.

But the problem is how to define the test case.

[yuhaowin]

[nacos-client] moudle current used org.apache.logging.slf4j.Log4jLogger implement, mvn test first load Log4J2NacosLogging then execute unit test.

[KomachiSion]

CLA not sign for a long time.