Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#344] rename initialization sql files #8969

Merged
merged 1 commit into from Aug 25, 2022

Conversation

yjqg6666
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fix #344 #5880 #2411.
重命名sql文件名,避免使用schema.sql作为mysql建库初始化mysql数据库。

Related issues

https://github.com/alibaba/nacos/issues?q=schema.sql+nacos-mysql.sql

Brief changelog

  • 重命名 schema.sql 为 derby-schema.sql
  • 重命名名 nacos-mysql.sql 为 mysql-schema.sql

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2022

CLA assistant check
All committers have signed the CLA.

@yjqg6666
Copy link
Contributor Author

./config/src/main/resources/META-INF/nacos-db.sql 这个文件跟 nacos-mysql.sql文件的用途有啥不同么? 看内容对比还是有些差别。 在目前的PR中没有修改这个文件名。

@yjqg6666
Copy link
Contributor Author

另外 这个文档 https://nacos.io/zh-cn/docs/deployment.html 可以通过修改哪里的代码PR上来(仓库地址或分支名)更新?

KomachiSion
KomachiSion previously approved these changes Aug 17, 2022
@KomachiSion
Copy link
Collaborator

另外 这个文档 https://nacos.io/zh-cn/docs/deployment.html 可以通过修改哪里的代码PR上来(仓库地址或分支名)更新?

nacos-group/

@KomachiSion
Copy link
Collaborator

@yjqg6666 麻烦同步一下develop分支的新改动,否则ci可能跑不过

@yjqg6666
Copy link
Contributor Author

@KomachiSion Rebased on the current develop branch.

@codecov-commenter
Copy link

Codecov Report

Merging #8969 (9c1f635) into develop (87d9efd) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8969      +/-   ##
=============================================
+ Coverage      43.48%   43.58%   +0.09%     
  Complexity      4746     4746              
=============================================
  Files            912      912              
  Lines          32584    32584              
  Branches        3761     3761              
=============================================
+ Hits           14170    14202      +32     
+ Misses         17011    16980      -31     
+ Partials        1403     1402       -1     
Impacted Files Coverage Δ
.../core/v2/event/publisher/NamingEventPublisher.java 75.00% <0.00%> (-1.25%) ⬇️
...nacos/naming/core/v2/upgrade/UpgradeJudgement.java 76.52% <0.00%> (+2.60%) ⬆️
...alibaba/nacos/client/config/impl/ClientWorker.java 54.97% <0.00%> (+4.67%) ⬆️
...m/alibaba/nacos/naming/misc/HttpClientManager.java 83.33% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdf9d04...9c1f635. Read the comment docs.

@KomachiSion KomachiSion merged commit cb3c78b into alibaba:develop Aug 25, 2022
KomachiSion pushed a commit to nacos-group/nacos-group.github.io that referenced this pull request Aug 25, 2022
li-xiao-shuang pushed a commit that referenced this pull request Aug 31, 2022
* Add exception detail stacks when connect to server failed.

* [ISSUE#8653]Fix health check bug (#8639)

* fix health bug.

* fix health bug.

* fix health bug.

* test update

* format code

* 注释

* check service exist

* check service exist

* test fail

* user group()

* add unit test.

* add unit test.

* add unit test.

* add unit test.

* add unit test.

* add unit test.

* Add comment for config aspect.

* [ISSUE#8481]Unified TRACE capacity building  (#8805)

* [ISSUE#8481]Unified TRACE capacity building

* [ISSUE#8481]Unified TRACE capacity building
1. Event type add to traceEvent.
2. The event about instance add instancePort.
3. Add health check type to healthChangeEvent.
4. Other fixup.

* Add Generic Type for Simple Cache Map (#8812)

* import config file auth fail (#8844)

* import config file auth fail

* run ci

* run ci2

* Feat/calculate ip count when use batchregister (#8858)

Feat/calculate ip count when use batchregister

* [ISSUE #8880] add a request exception handler (#8881)

* [ISSUE #8880] add a request exception handler

Close #8880

* [ISSUE #8880] retry ci

* Upgrade to 2.1.1 (#8899)

* [ISSUE#8910] bug fix calcu ipCount (#8911)

* bug fix calcu ipCount

* update logic

* judge endpoint (#8933)

* [ISSUE #8925] fix that the value of hasQueryString is always false (#8927)

Close #8925

* [ISSUES#8905]simplify some code (#8908)

* refactor: 💡 update console-ui theme (#8951)

✅ Closes: #8950

* Update IoUtils.java (#8948)

An IOException has been catch,so throws IOException Is invalid

* [ISSUE #8931] Fix bug :BatchInstanceData cannot Serializable question (#8940)

* [fix] fix BatchInstanceData cannot Serializable question

* fix update serialVersionUID auto generate

* [ISSUE #8925] fix that the replaceAll operation is invalid (#8929)

Close #8925

* fix #8947. (#8959)

* judge endpoint

* add some junit test (#8966)

* add some junit test

* fix some junit

* add license

* optimize: internationalization of product description content on landing pages (#8956)

* Improve code specifications. (#8965)

Flip the call to equals method to avoid null pointer exception.

* fix LookupFactoryTest  ut / ci (#8985)

* fix ci

* run ci

* check cla report

* check style

* add some auth plugin test (#8988)

* add some auth plugin test

* ru ci

* remove namespaceShowName uniqueness check (#8989)

* add unit test for ReflectUtils (#8999)

* add unit test for ReflectUtils

* reformat code

* [ISSUE #8993]Close input stream and output stream by try with resource[nacos-common] (#8997)

* [ISSUE #8993]Close input stream and output stream by try with resource[nacos-common]

* [ISSUE #8993]Close input stream and output stream by try with resource[nacos-common]

* [ISSUE #8993]Close input stream and output stream by try with resource[nacos-common]

* add some utils UT (#9006)

add some utils UT

* Fix grpc push data not filter by cluster. (#9019)

* [#344] rename initialization sql files (#8969)

* [ISSUE #9014] performance optimization--refacte TpsMonitorPoint (#9021)

* performance optimization

* fix check style

* fix test unit

* fix test unit for `getTimeFormatOfSecond` method.

* fix unit test  for LimiterTest.

* fix error usage case for asserEquals method;eliminate interactions between test methods

* Fix spelling mistakes. (#9026)

* [ISSUE #9013] enhance grpc client (#9017)

* fix issue #9013

* reformat code style

* reformat code style

* reformat code style

* reformat code style

* reformat code style

* reformat code style

* reformat code style

* change config name

* do some enhance

* add queue size to configProperties

* reformat code style

* Change configuration load order

* Fix ServerListMgr is not shutdown. (#9048)

* set server.error.include-message to ALWAYS (#9045)

* [ISSUE #8934] add header back after convert request to jsonBytes (#8935)

* [ISSUE #9023] fix corner case config dataId 'cipher-' that cannot create (#9024)

* [ISSUE #9023] fix corner case config dataId 'cipher-' that cannot create

* [ISSUE #9023] remove unused import

* [ISSUE #9023] PMD fix

* [ISSUE #9023] add comments

* [ISSUE #9023] should return first token instead of any

* [ISSUE #9023] add more EncryptionHandler ut

* [ISSUE #9023] fix style

* [ISSUE #9023] fix style, keep indentation in blank line

Co-authored-by: KomachiSion <xiweng.yy@alibaba-inc.com>
Co-authored-by: 胡俊 <510830970@qq.com>
Co-authored-by: MajorHe1 <53824889+MajorHe1@users.noreply.github.com>
Co-authored-by: GuiShao <zhupeng.zhu@alibaba-inc.com>
Co-authored-by: ZhangShenao <15201440436@163.com>
Co-authored-by: chenhao26 <35129699+chenhao26-nineteen@users.noreply.github.com>
Co-authored-by: onewe <admin@onew.me>
Co-authored-by: 胡俊 <hujun3@xiaomi.com>
Co-authored-by: liushaoyu-soft <455028117@qq.com>
Co-authored-by: heimanba <371510756@qq.com>
Co-authored-by: 无处不在 <42382506+wuchubuzai2018@users.noreply.github.com>
Co-authored-by: Weizhan Yun <yunweizhan@gmail.com>
Co-authored-by: liaochuntao <liaochuntao@live.com>
Co-authored-by: @xiaochangbai <704566072@qq.com>
Co-authored-by: shiherua <56618514+shiherua@users.noreply.github.com>
Co-authored-by: Karson <karsontao@hotmail.com>
Co-authored-by: yjqg6666 <jinking.this@gmail.com>
Co-authored-by: 阿魁 <670569467@qq.com>
Co-authored-by: wuwen <wuwen.55@aliyun.com>
Co-authored-by: hutt <200714916@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

初始化 Mysql 5.7.23 schema.sql 脚本语法不兼容问题
4 participants