Add a new option enableWarning

[zry656565]

• Add a new option enableWarning to determine if showing warning messages.
• It's helpful to disable warnings in prod environment.

[CLAassistant]

All committers have signed the CLA.

[spherop]

This is a must have for serious production use in my book. Is there a chance of merging?

[alexeyMohnatkin]

It's better to pass callback function instead of flag

intl.init({ 
  locales, 
  currentLocale,
  notDefinedHandler: R.identity,
});

#47

[cwtuan]

I prefer the solution from @alexeyMohnatkin. Please see the comment in the PR. Thanks.

[zry656565]

@cwtuan So why not just accpet Alexey's solution? It's fine to me. What I want is to solve the problem, no matter how.

Btw, I think the variable name, notDefinedHandler, may not be proper for this line (https://github.com/alibaba/react-intl-universal/pull/47/files#diff-1fdf421c05c1140f6d71444ea2b27638R83)

[cwtuan]

@zry656565 any suggestion for the variable name?

[zry656565]

@cwtuan Maybe a more general name like warningLogger or warningHandler? idk, it's up to you.

[zry656565]

And it would be better that the handler's type is defined as boolean | (message: string) => void in my opinion. because it's odd to define an empty function to disable warning. just a suggestion

[alexeyMohnatkin]

I agree that notDefinedHandler is not the best name. What if I add callback for each warning to handle them separately?

{
  ...
  msgNotFound: console.warn,
  msgFormatFailed: console.warn,
  langNotSupported: console.warn,
}

[alexeyMohnatkin]

@zry656565 I think it's bad practice to disable these warnings. You may never know that something's wrong

[cwtuan]

Fixed v1.11.1.
https://github.com/alibaba/react-intl-universal/releases/tag/1.11.1