Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the inveracious logging.Logger to customize. #201

Merged
merged 4 commits into from
Aug 12, 2020

Conversation

louyuting
Copy link
Collaborator

@louyuting louyuting commented Aug 11, 2020

Describe what this PR does / why we need it

In logging module, current implementation cannot customize Logger implementation by user.
Current exported function, logging.ResetDefaultLogger(), is not working as expected.

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@louyuting louyuting requested a review from sczyh30 August 11, 2020 13:08
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2020

Codecov Report

Merging #201 into master will decrease coverage by 0.26%.
The diff coverage is 14.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   44.25%   43.99%   -0.27%     
==========================================
  Files          80       80              
  Lines        4424     4453      +29     
==========================================
+ Hits         1958     1959       +1     
- Misses       2236     2264      +28     
  Partials      230      230              
Impacted Files Coverage Δ
api/tracer.go 37.50% <0.00%> (ø)
core/circuitbreaker/circuit_breaker.go 23.56% <0.00%> (ø)
core/circuitbreaker/rule.go 84.10% <0.00%> (ø)
core/flow/slot.go 0.00% <0.00%> (ø)
core/hotspot/cache/lru.go 53.77% <0.00%> (ø)
core/hotspot/concurrency_stat_slot.go 0.00% <0.00%> (ø)
core/hotspot/slot.go 33.33% <0.00%> (ø)
core/hotspot/traffic_shaping.go 63.15% <0.00%> (ø)
core/log/metric/aggregator.go 29.16% <0.00%> (ø)
core/log/metric/reader.go 0.00% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eec949...b0b357e. Read the comment docs.

@sczyh30 sczyh30 added the area/logging Issue related to logging of Sentinel label Aug 11, 2020
logging/logging.go Outdated Show resolved Hide resolved
@eddycjy
Copy link

eddycjy commented Aug 11, 2020

Thanks for the fix, I think it is basically available.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 added this to the 0.6.0 milestone Aug 12, 2020
@sczyh30 sczyh30 merged commit d0cf004 into alibaba:master Aug 12, 2020
@sczyh30
Copy link
Member

sczyh30 commented Aug 12, 2020

Nice work. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Issue related to logging of Sentinel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants