Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename system.SystemRule to system.Rule #222

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

louyuting
Copy link
Collaborator

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@sczyh30 sczyh30 added this to the 0.7.0 milestone Sep 3, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2020

Codecov Report

Merging #222 into master will decrease coverage by 0.06%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
- Coverage   42.63%   42.56%   -0.07%     
==========================================
  Files          84       84              
  Lines        4492     4485       -7     
==========================================
- Hits         1915     1909       -6     
+ Misses       2334     2333       -1     
  Partials      243      243              
Impacted Files Coverage Δ
core/system/rule.go 90.00% <66.66%> (ø)
ext/datasource/helper.go 57.65% <80.00%> (ø)
core/system/rule_manager.go 94.23% <100.00%> (ø)
core/system/slot.go 56.60% <100.00%> (ø)
core/flow/rule_manager.go 51.58% <0.00%> (-2.21%) ⬇️
core/flow/rule.go 0.00% <0.00%> (ø)
core/flow/slot.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e61cf47...4c20891. Read the comment docs.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 8b17e24 into alibaba:master Sep 3, 2020
@louyuting louyuting modified the milestones: 0.7.0, 0.6.1 Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants