refactoring: Delete "SlotName" in 'core/system/slot.go'. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 42.56% 42.53% -0.03%
==========================================
Files 84 84
Lines 4485 4483 -2
==========================================
- Hits 1909 1907 -2
Misses 2333 2333
Partials 243 243
Continue to review full report at Codecov.
|
louyuting
added
the
kind/enhancement
louyuting
approved these changes
Sep 6, 2020
|
@sdttttt Could you please join DingDing Group to discuss? |
Thanks. I will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
This attribute seems superfluous.
It doesn't seem to have been really used.
Describe how to verify it
Tests and Example can pass.