Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add jakarta annotation api (#3342) #3347

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

ruansheng8
Copy link
Collaborator

Describe what this PR does / why we need it

Does this pull request fix one issue?

Fixes #3342

Describe how you did it

Describe how to verify it

Special notes for reviews

Copy link
Collaborator

@steverao steverao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a strange thing, I can run mvn clean install in my local environment. :(
image

@ruansheng8
Copy link
Collaborator Author

ruansheng8 commented Jun 16, 2023

@DanielLiu1123 @123liuziming @complone 你们那边本地是否可以正常执行 mvn clean install (2021.x 分支)

@123liuziming
Copy link
Collaborator

123liuziming commented Jun 20, 2023

2021.x分支我可以成功构建
image

Copy link
Collaborator

@steverao steverao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add it to module of Nacos discovery.

@ruansheng8
Copy link
Collaborator Author

Please also add it to module of Nacos discovery.

done

Copy link
Collaborator

@steverao steverao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ruansheng8

@steverao steverao merged commit 2cbfceb into alibaba:2021.x Jun 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants