Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【WIP】Add maven-checkstyle-plugin to check code style #939

Closed
wants to merge 3 commits into from

Conversation

zhaoyuguang
Copy link
Contributor

@zhaoyuguang zhaoyuguang commented Sep 16, 2019

Describe what this PR does / why we need it

Add maven-checkstyle-plugin to check code style
My local repo test: zhaoyuguang#2

Does this pull request fix one issue?

#935

@zhaoyuguang
Copy link
Contributor Author

It seems don't refer https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/master/spring-cloud-dependencies-parent/eclipse-code-formatter.xml.

Yes, At the moment, I just want to make mvn checkstyle work. There is a useless import in our code, but it seems that CI has passed.

@zhaoyuguang
Copy link
Contributor Author

zhaoyuguang commented Sep 17, 2019

@fangjian0423 Hi, I can't find a correct way to finish this, such as
<setting id="org.eclipse.jdt.core.formatter.insert_space_after_ellipsis" value="insert"/>
at https://checkstyle.sourceforge.io/config_whitespace.html#NoWhitespaceAfter, there has no rule for insert_space_after_ellipsis

https://stackoverflow.com/questions/57974305/maven-checkstyle-plugin-can-use-code-format-file-directly

@fangjian0423
Copy link
Contributor

resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants