Skip to content

Commit

Permalink
* [android] move element bug fix
Browse files Browse the repository at this point in the history
  • Loading branch information
zshshr committed Nov 4, 2016
1 parent 0a59a85 commit dfc643d
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions android/sdk/src/main/java/com/taobao/weex/dom/WXDomStatement.java
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ void findFixed(WXDomObject obj){
* @param parentRef Reference of the new parent DOM node
* @param index the index of the dom to be inserted in the new parent.
*/
void moveDom(final String ref, final String parentRef, final int index) {
void moveDom(final String ref, final String parentRef, int index) {
if (mDestroy) {
return;
}
Expand All @@ -730,17 +730,23 @@ void moveDom(final String ref, final String parentRef, final int index) {
}
return;
}
if (domObject.parent.equals(parentObject) && parentObject.index(domObject) == index) {
return;
if (domObject.parent.equals(parentObject)) {
if(parentObject.index(domObject) == index) {
return;
} else if(domObject.parent.index(domObject)<index){
index = index -1;
}
}

final int newIndex = index;
domObject.parent.remove(domObject);
parentObject.add(domObject, index);
parentObject.add(domObject, newIndex);

mNormalTasks.add(new IWXRenderTask() {

@Override
public void execute() {
mWXRenderManager.moveComponent(mInstanceId, ref, parentRef, index);
mWXRenderManager.moveComponent(mInstanceId, ref, parentRef, newIndex);
}

@Override
Expand Down

0 comments on commit dfc643d

Please sign in to comment.