Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsfm] supported return value from native #1992

Closed
wants to merge 2 commits into from
Closed

[jsfm] supported return value from native #1992

wants to merge 2 commits into from

Conversation

Jinjiang
Copy link
Contributor

fixed #1677

  • callNativeModule(instanceId, module, method, arguments, options)
  • callNativeComponent(instanceId, componentRef, method, arguments, options)

Hanks10100
Hanks10100 approved these changes Dec 28, 2016
View reviewed changes
Copy link
Member

@Hanks10100 Hanks10100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

This feature has been reimplemented in jsfm-feature-0.19.

@Hanks10100
Copy link
Member

After discussion, this feature has been implemented in jsfm-feature-0.19, and have few difference with this code.

This PR will be closed.

@Hanks10100 Hanks10100 closed this Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hanks10100 Hanks10100 Hanks10100 approved these changes

@Tancy Tancy Awaiting requested review from Tancy

@fkysly fkysly Awaiting requested review from fkysly

Assignees

@Hanks10100 Hanks10100

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jinjiang @Hanks10100