Make snapshot reverting transactions cheaper

[vtleonardo]

Scope

What is changing with this PR?
This PR is reorganizing the snapshots method to revert earlier in case of re-submission of the same snapshots and doing some housekeeping for better organization. The re-org will also improve the messages we see on the golang side when multiple validators try to do the snapshot.

Gas used by a reverted transaction by doing re-submission of same snapshot data (without the full ring buffer):
Before this PR: 210266
After this PR: 53148

[codecov]

Codecov Report

Merging #157 (579b7af) into main (4b18e3e) will increase coverage by 0.05%.
The diff coverage is 92.50%.

@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   53.33%   53.39%   +0.05%     
==========================================
  Files         338      338              
  Lines       43025    43061      +36     
  Branches      366      366              
==========================================
+ Hits        22948    22993      +45     
+ Misses      17650    17641       -9     
  Partials     2427     2427              

Impacted Files	Coverage Δ
bridge/contracts/Snapshots.sol	94.01% <91.89%> (-1.91%)	⬇️
bridge/contracts/ETHDKG.sol	85.49% <100.00%> (+0.64%)	⬆️
badgerTrie/smt_merkle_proof.go	69.53% <0.00%> (ø)
bridge/contracts/utils/ImmutableAuth.sol	52.11% <0.00%> (+1.40%)	⬆️
...idge/contracts/libraries/StakingNFT/StakingNFT.sol	100.00% <0.00%> (+3.82%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ghost]

Go side of things look good.

[ghost]

If this is because of a linter warning for unused variables there might be a different workaround. Possibly removing the name from the signature, or replacing with a _:

function checkBClaimsSignature(bytes calldata, bytes calldata)

[vtleonardo]

Yep, this is to silence the linter. Unfortunately, we cannot change the signature (both name and variables) because this Mock needs to conform to the ISnapshots solidity interface.