Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace signature raw in the snapshots event #178

Merged
merged 49 commits into from
Aug 19, 2022

Conversation

vtleonardo
Copy link
Contributor

@vtleonardo vtleonardo commented Aug 17, 2022

This PR is changing the type of signatures being passed in the snapshot events. This should make snapshots a little bit cheaper and clear, as we will be reducing the extra 64 bytes overhead from the bytes serializing in the event data.

blocked by #157

@vtleonardo vtleonardo requested review from a team as code owners August 17, 2022 14:36
@github-actions github-actions bot added go Pull requests that update Go code javascript Pull requests that update Javascript code solidity labels Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #178 (9dd21d0) into main (b9ceed3) will increase coverage by 1.73%.
The diff coverage is 23.52%.

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   51.75%   53.49%   +1.73%     
==========================================
  Files         281      339      +58     
  Lines       40900    43092    +2192     
  Branches        0      358     +358     
==========================================
+ Hits        21169    23051    +1882     
- Misses      17309    17623     +314     
+ Partials     2422     2418       -4     
Impacted Files Coverage Δ
layer1/monitor/events/snapshots.go 0.00% <0.00%> (ø)
bridge/contracts/Snapshots.sol 94.11% <100.00%> (ø)
bridge/contracts/utils/ERC20SafeTransfer.sol 100.00% <0.00%> (ø)
bridge/contracts/Distribution.sol 100.00% <0.00%> (ø)
...ntracts/libraries/parsers/BClaimsParserLibrary.sol 100.00% <0.00%> (ø)
bridge/contracts/BToken.sol 97.03% <0.00%> (ø)
bridge/contracts/utils/CustomEnumerableMaps.sol 73.17% <0.00%> (ø)
bridge/contracts/ATokenMinter.sol 100.00% <0.00%> (ø)
bridge/contracts/libraries/metadata/StakingSVG.sol 100.00% <0.00%> (ø)
bridge/contracts/utils/EthSafeTransfer.sol 100.00% <0.00%> (ø)
... and 51 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nelsonhp nelsonhp merged commit e020d73 into alicenet:main Aug 19, 2022
@ghost ghost added the t/feature New feature or request label Aug 23, 2022
vtleonardo referenced this pull request in vtleonardo/alicenet Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code javascript Pull requests that update Javascript code solidity t/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants