Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused import #158

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Conversation

vtleonardo
Copy link
Contributor

Scope

What is changing with this PR?

Removing unused import from validator.go file.

Why?

Why are we doing this?
Removing potential vulnerability

@vtleonardo vtleonardo requested a review from a team as a code owner August 11, 2022 18:37
@github-actions github-actions bot added the go Pull requests that update Go code label Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #158 (69b8b73) into main (775eed8) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   51.32%   51.31%   -0.02%     
==========================================
  Files         337      337              
  Lines       42999    42999              
  Branches      362      362              
==========================================
- Hits        22071    22065       -6     
- Misses      18590    18592       +2     
- Partials     2338     2342       +4     
Impacted Files Coverage Δ
badgerTrie/smt_merkle_proof.go 65.62% <0.00%> (-3.91%) ⬇️
peering/active.go 83.01% <0.00%> (-0.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! gosec linter would be flagging this soon. We can also hook up Google Cloud Profiler in the future which will give us the ability to compare versions in a more secure fashion.

@vtleonardo vtleonardo merged commit cef7c49 into alicenet:main Aug 11, 2022
vtleonardo referenced this pull request in vtleonardo/alicenet Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant