-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up validator pool contract #188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #188 +/- ##
==========================================
+ Coverage 51.68% 51.69% +0.01%
==========================================
Files 283 283
Lines 41140 41140
==========================================
+ Hits 21264 21269 +5
+ Misses 17453 17452 -1
+ Partials 2423 2419 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nelsonhp
approved these changes
Aug 21, 2022
bridge/contracts/ValidatorPool.sol
Outdated
@@ -64,18 +76,36 @@ contract ValidatorPool is | |||
function initialize( | |||
uint256 stakeAmount_, | |||
uint256 maxNumValidators_, | |||
uint256 disputerReward_ | |||
uint256 disputerReward_, | |||
uint256 maxIntervalWithoutSnapshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add _ to end to conform with standard pattern
vtleonardo
referenced
this pull request
in vtleonardo/alicenet
Sep 26, 2022
* Simplifying devcontainer and misc fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR: