Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up validator pool contract #188

Merged
merged 6 commits into from
Aug 21, 2022
Merged

Clean up validator pool contract #188

merged 6 commits into from
Aug 21, 2022

Conversation

vtleonardo
Copy link
Contributor

This is PR:

  • Cleaning up the validator pool contract to make deployment less expensive
  • Adding the ability to set the max number of Ethereum blocks without a snapshot (amount where we are allowed to kick the validators out).

@vtleonardo vtleonardo requested a review from a team as a code owner August 21, 2022 18:46
@github-actions github-actions bot added javascript Pull requests that update Javascript code solidity labels Aug 21, 2022
@codecov
Copy link

codecov bot commented Aug 21, 2022 •
edited

Codecov Report

Merging #188 (b0a4dbf) into main (ada6a18) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   51.68%   51.69%   +0.01%     
==========================================
  Files         283      283              
  Lines       41140    41140              
==========================================
+ Hits        21264    21269       +5     
+ Misses      17453    17452       -1     
+ Partials     2423     2419       -4
Impacted Files Coverage Δ
badgerTrie/smt_merkle_proof.go 69.53% <0.00%> (+3.90%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vtleonardo vtleonardo requested a review from a team as a code owner August 21, 2022 18:57
@github-actions github-actions bot added the go Pull requests that update Go code label Aug 21, 2022
nelsonhp
nelsonhp approved these changes Aug 21, 2022
View reviewed changes
bridge/contracts/ValidatorPool.sol Outdated
@@ -64,18 +76,36 @@ contract ValidatorPool is
function initialize(
uint256 stakeAmount_,
uint256 maxNumValidators_,
uint256 disputerReward_
uint256 disputerReward_,
uint256 maxIntervalWithoutSnapshots
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add _ to end to conform with standard pattern

@nelsonhp nelsonhp merged commit 52136b6 into alicenet:main Aug 21, 2022
vtleonardo referenced this pull request in vtleonardo/alicenet Sep 26, 2022
Simplifying devcontainer and misc fixes (#188)
8112c4d 
* Simplifying devcontainer and misc fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonhp nelsonhp nelsonhp approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code javascript Pull requests that update Javascript code solidity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vtleonardo @nelsonhp