Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up script log output #231

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Conversation

vtleonardo
Copy link
Contributor

@vtleonardo vtleonardo commented Aug 30, 2022

Scope

This PR is removing some unnecessary logs to improve UX and improving some logs (e.g displaying AToken and BToken as ALCA and ALCB in the logs during deployment).

@vtleonardo vtleonardo requested a review from a team as a code owner August 30, 2022 21:23
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 53.09% // Head: 53.08% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (ea22da3) compared to base (eb0781a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   53.09%   53.08%   -0.02%     
==========================================
  Files         344      344              
  Lines       43172    43172              
  Branches      544      544              
==========================================
- Hits        22922    22917       -5     
- Misses      17837    17838       +1     
- Partials     2413     2417       +4     
Impacted Files Coverage Δ
badgerTrie/smt_merkle_proof.go 65.62% <0.00%> (-3.91%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@z-j-lin z-j-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@vtleonardo vtleonardo merged commit df904bc into alicenet:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants