Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task name hyphenation + ALCA/ALCB in task names #250

Merged
merged 9 commits into from
Sep 22, 2022
Merged

Task name hyphenation + ALCA/ALCB in task names #250

merged 9 commits into from
Sep 22, 2022

Conversation

keirongulrajani
Copy link
Contributor

Scope

  • Updated task names to use hyphenated standard
  • Replaced some instances of AToken/BToken with ALCA/ALCB

Why?

MP-858
MP-858

Todos

If any, what are the follow-up tasks required other than merging this PR? Have they been arranged?

  • ???

@keirongulrajani
Updated task names to use hyphenated standard
0482e55 
Replaced some instances of AToken/BToken with ALCA/ALCB
@keirongulrajani keirongulrajani requested a review from a team as a code owner September 7, 2022 09:58
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022 •
edited
Loading

Codecov Report

Base: 53.09% // Head: 53.09% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d3261e2) compared to base (df904bc).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   53.09%   53.09%           
=======================================
  Files         344      344           
  Lines       43172    43172           
  Branches      544      544           
=======================================
+ Hits        22921    22922    +1     
- Misses      17835    17837    +2     
+ Partials     2416     2413    -3
Impacted Files Coverage Δ
peering/active.go 83.01% <0.00%> (-0.95%) ⬇️
transport/brontide/noise.go 89.21% <0.00%> (-0.68%) ⬇️
badgerTrie/smt_merkle_proof.go 69.53% <0.00%> (+3.90%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

z-j-lin
z-j-lin suggested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@z-j-lin z-j-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove deploymetamorphic from readme

bridge/README.md Outdated Show resolved Hide resolved
z-j-lin
z-j-lin approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@z-j-lin z-j-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@vtleonardo vtleonardo merged commit 539584a into alicenet:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z-j-lin z-j-lin z-j-lin approved these changes

@vtleonardo vtleonardo vtleonardo approved these changes

Assignees
No one assigned
Labels
area/docs javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keirongulrajani @z-j-lin @vtleonardo