Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Coverage for Node #26

Merged
9 commits merged into from
Jul 22, 2022
Merged

CI Coverage for Node #26

9 commits merged into from
Jul 22, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 28, 2022

Scope

Fixes up coverage runs for solidity.

@vtleonardo
Copy link
Contributor

Solidity coverage is failing due to some typescript dependencies. Other than that, LGTM!

@vtleonardo vtleonardo self-requested a review June 30, 2022 16:28
@ghost
Copy link
Author

ghost commented Jul 6, 2022

Holding off on committing until I can get the CI tests fixed up along with the node dependabot ones.

@ghost
Copy link
Author

ghost commented Jul 6, 2022

Blocked on #30

@github-actions github-actions bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code actions labels Jul 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #26 (39cd395) into main (4ad6cb8) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   48.93%   48.93%   -0.01%     
==========================================
  Files         287      287              
  Lines       42317    42317              
==========================================
- Hits        20708    20707       -1     
- Misses      19249    19250       +1     
  Partials     2360     2360              
Impacted Files Coverage Δ
peering/active.go 83.01% <0.00%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad6cb8...39cd395. Read the comment docs.

madhivedan added 2 commits July 6, 2022 15:48
Fixing missing action
Bumping up timeout
@ghost ghost changed the title Update hardhat CI Coverage for Node Jul 11, 2022
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Jul 21, 2022
@ghost ghost merged commit d95992a into main Jul 22, 2022
@ghost ghost deleted the update-hardhat branch July 22, 2022 14:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants