[291] Enable lint errcheck

.devcontainer/devcontainer.json

@@ -18,7 +18,11 @@
         "go.toolsManagement.checkForUpdates": "local",
         "go.useLanguageServer": true,
         "go.gopath": "/go",
-        "go.goroot": "/usr/local/go"
+        "go.goroot": "/usr/local/go",
+        "go.lintTool": "golangci-lint",
+        "go.lintFlags": [
+          "--fast"
+        ]
       },
       "extensions": [
         "golang.Go",

.golangci.yaml

@@ -4,9 +4,10 @@ run:
     - integration
     - flakes
 linters:
+  enable:
+    - errcheck
   # Disabling linters until we get them fixed up.
   disable:
-    - errcheck
     - gosimple
     - govet
     - ineffassign

cmd/testutils/layer1_tx_spammer/main.go

@@ -283,7 +283,9 @@ func main() {
 	defer watcher.Close()
 	if isUsingTestAccounts {
 		// this function will block for finality delay blocks
-		tests.FundAccounts(eth, watcher, logger)
+		if err := tests.FundAccounts(eth, watcher, logger); err != nil {
+			panic("Unable to fund test accounts")
+		}
 		tests.SetNextBlockBaseFee(eth.GetEndpoint(), 100_000_000_000)
 	}
 

consensus/objs/rs.go

@@ -465,6 +465,7 @@ func (b *RoundState) TrackExternalConflicts(v *Proposal) {
 		return
 	}
 	// is current
+	// nolint:errcheck // review error checking for RoundState
 	b.checkStaleAndConflict(v, false)
 }
 

dynamics/db_test.go

@@ -37,7 +37,7 @@ func TestMock(t *testing.T) {
 
 	m := NewTestDB()
 
-	m.DB().Update(func(txn *badger.Txn) error {
+	err := m.DB().Update(func(txn *badger.Txn) error {
 		_, err := m.GetValue(txn, key)
 		if !errors.Is(err, ErrKeyNotPresent) {
 			t.Fatalf("should have failed: %v", err)
@@ -57,6 +57,9 @@ func TestMock(t *testing.T) {
 		}
 		return nil
 	})
+	if err != nil {
+		t.Fatal("unable to complete test")
+	}
 
 }
 
@@ -78,7 +81,7 @@ func TestGetSetNode(t *testing.T) {
 	db := initializeDB()
 
 	node := &Node{}
-	db.rawDB.Update(func(txn *badger.Txn) error {
+	err := db.rawDB.Update(func(txn *badger.Txn) error {
 		err := db.SetNode(txn, node)
 		if err == nil {
 			t.Fatal("Should have raised error (1)")
@@ -117,14 +120,17 @@ func TestGetSetNode(t *testing.T) {
 		}
 		return nil
 	})
+	if err != nil {
+		t.Fatal("unable to complete test")
+	}
 }
 
 func TestGetSetLinkedList(t *testing.T) {
 	t.Parallel()
 	db := initializeDB()
 
 	ll := &LinkedList{}
-	db.rawDB.Update(func(txn *badger.Txn) error {
+	err := db.rawDB.Update(func(txn *badger.Txn) error {
 		err := db.SetLinkedList(txn, ll)
 		if err == nil {
 			t.Fatal("Should have raised error (1)")
@@ -148,4 +154,7 @@ func TestGetSetLinkedList(t *testing.T) {
 		}
 		return nil
 	})
+	if err != nil {
+		t.Fatal("unable to complete test")
+	}
 }

dynamics/dynamics_test.go

@@ -148,7 +148,10 @@ func TestStorageInit1(t *testing.T) {
 func TestStorageInitFromScratch(t *testing.T) {
 	t.Parallel()
 	s := &Storage{}
-	s.Init(NewTestDB(), newLogger())
+	err := s.Init(NewTestDB(), newLogger())
+	if err != nil {
+		t.Fatal("Database not initialized")
+	}
 
 	// since there's no node, the starting channel should be closed and no request
 	// against the storage should be allowed
@@ -171,7 +174,10 @@ func TestStorageInitWithPersistance(t *testing.T) {
 	}
 
 	s2 := &Storage{}
-	s2.Init(s.database.rawDB, s.logger)
+	err = s2.Init(s.database.rawDB, s.logger)
+	if err != nil {
+		t.Fatal("unable to initialize storage")
+	}
 
 	// Check dynamicValues == standardParameters
 	storageDVBytes, err := s2.DynamicValues.Marshal()

layer1/executor/task_executor.go

@@ -113,7 +113,10 @@ func (te *TaskExecutor) handleTaskExecution(task tasks.Task, name string, taskId
 	// Clean up in case the task was killed
 	if task.WasKilled() {
 		task.GetLogger().Trace("task was externally killed, removing tx backup")
-		te.removeTxBackup(task.GetId())
+		err := te.removeTxBackup(task.GetId())
+		if err != nil {
+			task.GetLogger().Error("removal of tx back up failure")
+		}
 	}
 	task.Finish(err)
 }

layer1/executor/task_manager.go

@@ -4,13 +4,14 @@ import (
 	"context"
 	"encoding/json"
 	"errors"
-	"github.com/alicenet/alicenet/layer1/executor/tasks/dkg"
-	"github.com/alicenet/alicenet/layer1/executor/tasks/snapshots"
 	"reflect"
 	"strings"
 	"sync"
 	"time"
 
+	"github.com/alicenet/alicenet/layer1/executor/tasks/dkg"
+	"github.com/alicenet/alicenet/layer1/executor/tasks/snapshots"
+
 	"github.com/dgraph-io/badger/v2"
 	"github.com/sirupsen/logrus"
 
@@ -121,7 +122,7 @@ func (tm *TaskManager) eventLoop() {
 
 		case taskRequest, ok := <-tm.requestChan:
 			if !ok {
-				tm.onError(ErrReceivedRequestClosedChan)
+				_ = tm.onError(ErrReceivedRequestClosedChan)
 				return
 			}
 			if taskRequest.response == nil {
@@ -160,10 +161,14 @@ func (tm *TaskManager) eventLoop() {
 				}
 			}
 			taskRequest.response.sendResponse(response)
-			tm.persistState()
+			err := tm.persistState()
+			if err != nil {
+				tm.logger.WithError(err).Logger.Warn("presist state failed")
+			}
 		case taskResponse, ok := <-tm.responseChan.erChan:
 			if !ok {
-				tm.onError(ErrReceivedResponseClosedChan)
+				//nolint:errcheck // Intentionally logging and swallowing error
+				_ = tm.onError(ErrReceivedResponseClosedChan)
 				return
 			}
 
@@ -173,7 +178,10 @@ func (tm *TaskManager) eventLoop() {
 				tm.logger.WithError(err).Errorf("Failed to processTaskResponse %v", taskResponse)
 				continue
 			}
-			tm.persistState()
+			err = tm.persistState()
+			if err != nil {
+				tm.logger.WithError(err).Errorf("Unable to presistState")
+			}
 		case <-processingTime:
 			tm.logger.Trace("processing latest height")
 			networkCtx, networkCf := context.WithTimeout(context.Background(), tasks.ManagerNetworkTimeout)

layer1/executor/tasks/tests/register_test.go

@@ -239,7 +239,8 @@ func TestRegisterTask_Group_1_Bad1(t *testing.T) {
 	dkgState.TransportPrivateKey = big.NewInt(0)
 	// Mess up public key; this should fail because it is invalid
 	dkgState.TransportPublicKey = [2]*big.Int{big.NewInt(0), big.NewInt(1)}
-	state.SaveDkgState(dkgDb, dkgState)
+	err = state.SaveDkgState(dkgDb, dkgState)
+	assert.NotNil(t, err)
 	_, err = registrationTask.Execute(ctx)
 	assert.NotNil(t, err)
 }
@@ -299,7 +300,8 @@ func TestRegisterTask_Group_2_Bad2(t *testing.T) {
 	dkgState.TransportPrivateKey = big.NewInt(0)
 	// Mess up public key; this should fail because it is invalid (the identity element)
 	dkgState.TransportPublicKey = [2]*big.Int{big.NewInt(0), big.NewInt(0)}
-	state.SaveDkgState(dkgDb, dkgState)
+	err = state.SaveDkgState(dkgDb, dkgState)
+	assert.NotNil(t, err)
 	_, err = registrationTask.Execute(ctx)
 	assert.NotNil(t, err)
 }